You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/07 07:18:04 UTC

[GitHub] [flink] bzhaoopenstack opened a new pull request, #20193: [FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

bzhaoopenstack opened a new pull request, #20193:
URL: https://github.com/apache/flink/pull/20193

   Flink Connector support the jdbc connection with Mysql series DB, such as MySQL, MariaDB,
   Percona and etc. But we see the doc reference[1] shows the Mariadb Connector/J 3.0 will
   accepts jdbc:mariadb: as the protocal in connection strings by default. So we need to apply
   this change in our mysql jdbc connection vailidation. Mariadb Connector/J 2.X still support
   both "jdbc:mysql:" and "jdbc:mariadb:".
   
   [1] https://mariadb.com/kb/en/about-mariadb-connector-j/#jdbcmysql-scheme-compatibility
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
   
   
   ## Brief change log
   
   *(for example:)*
     - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
     - *Deployments RPC transmits only the blob storage reference*
     - *TaskManagers retrieve the TaskInfo from the blob cache*
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1178888424

   I would expect that we add MariaDB to the `JdbcExactlyOnceSinkE2eTest` with the correct test container and have a MariaDB dialect implemented (even if that would be just a copy of MySQL)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1183354699

   @afedulov Do you want to have a look at this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1201211346

   @bzhaoopenstack I won't be able to review this at the moment, but keep in mind that the CI is still failing for this PR. It makes sense to make sure that the CI works before the review actually starts. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20193: [FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1330776493

   We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Peng-Lei commented on pull request #20193: [FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1177205191

   +1， After the change. We can use mariadb driver to connect the mysql through by setting the jdbcOptions of `driver` parameter without change the url prefix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
bzhaoopenstack commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1186671889

   Hi all. @MartijnVisser @hadronzoo any updates on this one? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
bzhaoopenstack commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1221772980

   Sorry for late update. ;-) . Let's wait the azure test result. I got pass on my local env.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
bzhaoopenstack commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1178704968

   > @bzhaoopenstack Thanks for the PR, but in order to add support for MariaDB I would also like to see a test and documentation in place.
   
   Hi @MartijnVisser, I have a question here, you said you want a test for this PR, does it mean we should add a specific UT which only verify the jdbc conncetion strings?  Because I didn't find any existing UT in Flink.
   And notes: We only use Mysql connector to connect MariaDB, as it is a Mysql-series database.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
bzhaoopenstack commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1188958168

   > @bzhaoopenstack Are you ready？If yes, please change the title without "WIP".
   
   Yeah, I'm ready for the kind suggest from @MartijnVisser and @hadronzoo . ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Peng-Lei commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1188787860

   @bzhaoopenstack Are you ready？If yes, please change the title without "WIP". 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
bzhaoopenstack commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1178417684

   > @bzhaoopenstack Thanks for the PR, but in order to add support for MariaDB I would also like to see a test and documentation in place.
   
   Thanks very much for reply and suggest. I will add the test and documentation. Once I'm finish, I think I need your kind review and advice. Thank you. ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
bzhaoopenstack commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1201305262

   > @bzhaoopenstack I won't be able to review this at the moment, but keep in mind that the CI is still failing for this PR. It makes sense to make sure that the CI works before the review actually starts.
   
   OK, thank you Martijn. I will resolve it and make it ready for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Peng-Lei commented on a diff in pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on code in PR #20193:
URL: https://github.com/apache/flink/pull/20193#discussion_r918776111


##########
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/mysql/MySqlDialectFactory.java:
##########
@@ -27,7 +27,7 @@
 public class MySqlDialectFactory implements JdbcDialectFactory {
     @Override
     public boolean acceptsURL(String url) {
-        return url.startsWith("jdbc:mysql:");
+        return (url.startsWith("jdbc:mysql:") || url.startsWith("jdbc:mariadb:"));

Review Comment:
   I think no need change here after we add `MariaDBDialectFactory`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
bzhaoopenstack commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1225168894

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser closed pull request #20193: [FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
MartijnVisser closed pull request #20193: [FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation
URL: https://github.com/apache/flink/pull/20193


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20193: [FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1177188510

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "deb8d27f47c263fae38e578e254a432b3d94d343",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "deb8d27f47c263fae38e578e254a432b3d94d343",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * deb8d27f47c263fae38e578e254a432b3d94d343 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
bzhaoopenstack commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1179836772

   > I would expect that we add MariaDB to the `JdbcExactlyOnceSinkE2eTest` with the correct test container and have a MariaDB dialect implemented (even if that would be just a copy of MySQL)
   
   Thanks for explain more, this is a good direction/suggestion for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bzhaoopenstack commented on pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Posted by GitBox <gi...@apache.org>.
bzhaoopenstack commented on PR #20193:
URL: https://github.com/apache/flink/pull/20193#issuecomment-1181548566

   Hi @MartijnVisser , sorry for late.
   And this is my first PR in flink, so I wish you could leave some kind directions and suggestions. Thank you very much. ;-). And hope this doesn't disturb you so much.
   
   Now, I will request an new review from your side, once we both think this PR is ready, I will remove the title [WIP]. ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org