You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/05/09 08:01:24 UTC
[GitHub] [incubator-doris] hffariel opened a new pull request #3535: [Feature]add documents' fulltext search
hffariel opened a new pull request #3535:
URL: https://github.com/apache/incubator-doris/pull/3535
add documents' fulltext search powered by algolia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3535: [Feature]support documents' fulltext searching
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3535:
URL: https://github.com/apache/incubator-doris/pull/3535#discussion_r422486485
##########
File path: docs/.vuepress/config.js
##########
@@ -90,7 +106,8 @@ module.exports = {
sidebar: convertSidebar(require('./sidebar/en.js'), '/en/')
},
'/zh-CN/': {
- selectText: 'Languages',
+ algolia: buildAlgoliaSearchConfig('zh-CN'),
+ selectText: '选择语言',
Review comment:
`选择语言` should always be in English. Both in `zh-CN` and `en` version.
For foreigner, they don't know and `选择语言` is `Language`. so that he can not found how to change language.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hffariel commented on pull request #3535: [Feature]support documents' fulltext searching
Posted by GitBox <gi...@apache.org>.
hffariel commented on pull request #3535:
URL: https://github.com/apache/incubator-doris/pull/3535#issuecomment-626451277
> By the way, could you please add the branch name you try to merge to in your PR title?
> Or there are 3 PR with same name.
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org