You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ankita Sinha <an...@freestoneinfotech.com> on 2017/06/13 08:23:25 UTC

Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60034/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1582
    https://issues.apache.org/jira/browse/RANGER-1582


Repository: ranger


Description
-------

Actual :
Currently Knox SSO is just supported from Ranger UI through web browser.

Expected :
Support KNOX SSO Token based authentication on Ranger REST API calls.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java ffb60b9 
  security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3 


Diff: https://reviews.apache.org/r/60034/diff/1/


Testing
-------

1. Checked Knox SSO for REST API Calls
2. Knox SSO working as expected from Ranger UI
3. Tested in secure as well as simple environment.


Thanks,

Ankita Sinha


Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

Posted by Ankita Sinha <an...@freestoneinfotech.com>.

> On June 13, 2017, 8:49 a.m., Colm O hEigeartaigh wrote:
> > Please put curly brackets around the two one-line if statements: if(LOG.isDebugEnabled())

Thanks, updated with the suggested changes.


- Ankita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60034/#review177715
-----------------------------------------------------------


On June 13, 2017, 9:55 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60034/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 9:55 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1582
>     https://issues.apache.org/jira/browse/RANGER-1582
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Actual :
> Currently Knox SSO is just supported from Ranger UI through web browser.
> 
> Expected :
> Support KNOX SSO Token based authentication on Ranger REST API calls.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java ffb60b9 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml f0ccae1 
> 
> 
> Diff: https://reviews.apache.org/r/60034/diff/2/
> 
> 
> Testing
> -------
> 
> 1. Checked Knox SSO for REST API Calls
> 2. Knox SSO working as expected from Ranger UI
> 3. Tested in secure as well as simple environment.
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60034/#review177715
-----------------------------------------------------------



Please put curly brackets around the two one-line if statements: if(LOG.isDebugEnabled())

- Colm O hEigeartaigh


On June 13, 2017, 8:23 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60034/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 8:23 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1582
>     https://issues.apache.org/jira/browse/RANGER-1582
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Actual :
> Currently Knox SSO is just supported from Ranger UI through web browser.
> 
> Expected :
> Support KNOX SSO Token based authentication on Ranger REST API calls.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java ffb60b9 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/60034/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Checked Knox SSO for REST API Calls
> 2. Knox SSO working as expected from Ranger UI
> 3. Tested in secure as well as simple environment.
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60034/#review177726
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On June 13, 2017, 9:55 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60034/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 9:55 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1582
>     https://issues.apache.org/jira/browse/RANGER-1582
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Actual :
> Currently Knox SSO is just supported from Ranger UI through web browser.
> 
> Expected :
> Support KNOX SSO Token based authentication on Ranger REST API calls.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java ffb60b9 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml f0ccae1 
> 
> 
> Diff: https://reviews.apache.org/r/60034/diff/2/
> 
> 
> Testing
> -------
> 
> 1. Checked Knox SSO for REST API Calls
> 2. Knox SSO working as expected from Ranger UI
> 3. Tested in secure as well as simple environment.
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60034/#review177727
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On June 13, 2017, 9:55 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60034/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 9:55 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1582
>     https://issues.apache.org/jira/browse/RANGER-1582
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Actual :
> Currently Knox SSO is just supported from Ranger UI through web browser.
> 
> Expected :
> Support KNOX SSO Token based authentication on Ranger REST API calls.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java ffb60b9 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml f0ccae1 
> 
> 
> Diff: https://reviews.apache.org/r/60034/diff/2/
> 
> 
> Testing
> -------
> 
> 1. Checked Knox SSO for REST API Calls
> 2. Knox SSO working as expected from Ranger UI
> 3. Tested in secure as well as simple environment.
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60034/
-----------------------------------------------------------

(Updated June 13, 2017, 9:55 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Included curly brackets around the two one-line if statements: if(LOG.isDebugEnabled())


Bugs: RANGER-1582
    https://issues.apache.org/jira/browse/RANGER-1582


Repository: ranger


Description
-------

Actual :
Currently Knox SSO is just supported from Ranger UI through web browser.

Expected :
Support KNOX SSO Token based authentication on Ranger REST API calls.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java ffb60b9 
  security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml f0ccae1 


Diff: https://reviews.apache.org/r/60034/diff/2/

Changes: https://reviews.apache.org/r/60034/diff/1-2/


Testing
-------

1. Checked Knox SSO for REST API Calls
2. Knox SSO working as expected from Ranger UI
3. Tested in secure as well as simple environment.


Thanks,

Ankita Sinha