[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1816: v2 segment support string encode(#1766)

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #1816: v2 segment support string encode(#1766)
URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r328181001
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/encoding_info.cpp
 ##########
 @@ -67,6 +68,18 @@ struct TypeEncodingTraits<type, RLE> {
     }
 };
 
+template<FieldType type>
+struct TypeEncodingTraits<type, DICT_ENCODING> {
+    static Status create_page_builder(const PageBuilderOptions& opts, PageBuilder** builder) {
+        *builder = new BinaryDictPageBuilder(opts);
+        return Status::OK();
 
 Review comment:
   maybe this type function can return void

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org