[jira] [Commented] (OFBIZ-5869) correction to changeset r1626462 and r1626463

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245279#comment-14245279 ] 

Jacques Le Roux commented on OFBIZ-5869:
----------------------------------------

Hi Leon, I can't apply your patch completely. Could you please create a new one? Thanks!

> correction to changeset r1626462  and r1626463  
> ------------------------------------------------
>
>                 Key: OFBIZ-5869
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5869
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>             Fix For: Trunk
>
>         Attachments: OFBIZ-5869.patch
>
>
> There's error in this commit. e.g.
> – List<GenericValue> allPCMPs = EntityUtil.filterByDate(delegator.findByAnd("PartyContactMechPurpose", pcmpFindMap, null, false), true);
> ++ allPCWPs = EntityUtil.filterByDate(allPCWPs, null, "contactFromDate", "contactThruDate", true);
> According to EntityUtil.filterByDate(List, EntityCondition, String, String ,Boolean), it filter nothing if condition parameter (the second) is null.
> see OFBIZ-5261.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)