[GitHub] [spark] imback82 commented on a change in pull request #30878: [SPARK-33872][SQL] Throw more specific exceptions when relations/namespaces are not found

[GitBox <gi...@apache.org>]

imback82 commented on a change in pull request #30878:
URL: https://github.com/apache/spark/pull/30878#discussion_r547619421



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -99,10 +99,10 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
         throw QueryExecutionErrors.logicalPlanHaveOutputOfCharOrVarcharError(leaf)
 
       case u: UnresolvedNamespace =>
-        u.failAnalysis(s"Namespace not found: ${u.multipartIdentifier.quoted}")
+        throw new NoSuchNamespaceException(s"Namespace not found: ${u.multipartIdentifier.quoted}")

Review comment:
       Should we close this PR or update `NoSuchNamespaceException` and `NoSuchTableException` to handle positions?
   
   Btw, it looks like there is a bug in keeping the position. I will fix it separately.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org