You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/02/05 22:05:53 UTC
[kudu-CR] [tools] KUDU-2688 rebalancer should not fix RF=2 violations
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12375
Change subject: [tools] KUDU-2688 rebalancer should not fix RF=2 violations
......................................................................
[tools] KUDU-2688 rebalancer should not fix RF=2 violations
This patch addresses KUDU-2688. Prior to this patch, the LA rebalancing
logic would suggest moves to reinstate the placement policy various
distributions of RF=2 tablet's replicas. As a result, the rebalancer
looped indefinitely trying to implement the suggested replica movements.
However, RF=2 is a special case: any replica distribution of a tablet
with RF=2 is a violations of the placement policy constraints and it's
impossible to fix that, regardless of the number of locations
in a Kudu cluster.
With this patch, the rebalancer no longer tries to correct non-fixable
violations of the placement policy for RF=2.
Change-Id: I3afc7f3a228368e8646b46914ec7c31234a6aa85
---
M src/kudu/tools/placement_policy_util-test.cc
M src/kudu/tools/placement_policy_util.cc
2 files changed, 57 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/12375/1
--
To view, visit http://gerrit.cloudera.org:8080/12375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3afc7f3a228368e8646b46914ec7c31234a6aa85
Gerrit-Change-Number: 12375
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tools] KUDU-2688 rebalancer should not fix RF=2 violations
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12375 )
Change subject: [tools] KUDU-2688 rebalancer should not fix RF=2 violations
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3afc7f3a228368e8646b46914ec7c31234a6aa85
Gerrit-Change-Number: 12375
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 22:07:57 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] KUDU-2688 rebalancer should not fix RF=2 violations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12375 )
Change subject: [tools] KUDU-2688 rebalancer should not fix RF=2 violations
......................................................................
[tools] KUDU-2688 rebalancer should not fix RF=2 violations
This patch addresses KUDU-2688. Prior to this patch, the LA rebalancing
logic would suggest moves to reinstate the placement policy various
distributions of RF=2 tablet's replicas. As a result, the rebalancer
looped indefinitely trying to implement the suggested replica movements.
However, RF=2 is a special case: any replica distribution of a tablet
with RF=2 is a violations of the placement policy constraints and it's
impossible to fix that, regardless of the number of locations
in a Kudu cluster.
With this patch, the rebalancer no longer tries to correct non-fixable
violations of the placement policy for RF=2.
Change-Id: I3afc7f3a228368e8646b46914ec7c31234a6aa85
Reviewed-on: http://gerrit.cloudera.org:8080/12375
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/placement_policy_util-test.cc
M src/kudu/tools/placement_policy_util.cc
2 files changed, 57 insertions(+), 0 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3afc7f3a228368e8646b46914ec7c31234a6aa85
Gerrit-Change-Number: 12375
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>