You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/08/15 15:52:37 UTC

[PR] [Studio] fix: canonicalize alert channel entries [rocketmq-dashboard]

btlqql opened a new pull request, #2259:
URL: https://github.com/apache/rocketmq-dashboard/pull/2259

   ## Summary
   
   - reject null and blank notification-channel entries at the alert rule request boundary
   - trim and stable-deduplicate channels during DTO-to-domain conversion
   - defensively canonicalize channel lists before persistence for internal callers
   - normalize legacy comma-separated channel rows when loading alert rules
   
   ## Problem
   
   Alert rule channels were accepted as unconstrained string-list elements. A null element reached `String.join` and caused a server error, while blank, padded, and duplicate values were stored unchanged and could represent repeated notification destinations.
   
   ## Verification
   
   - `AlertRuleRequestDTOTest,MybatisPlusAlertRepositoryTest,AlertRuleControllerTest,AlertServiceTest`: 72 tests passed
   - `mvn -DskipTests package`: passed
   - Maven Checkstyle: 0 violations
   - `git diff --check`
   
   Closes #2258
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Studio] fix: canonicalize alert channel entries [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2259:
URL: https://github.com/apache/rocketmq-dashboard/pull/2259#issuecomment-5338109861

   Consolidated into #2243 (merged as c406a0cc) per the batch integration of related small fixes — closing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Studio] fix: canonicalize alert channel entries [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2259: [Studio] fix: canonicalize alert channel entries
URL: https://github.com/apache/rocketmq-dashboard/pull/2259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org