You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2009/08/27 17:19:01 UTC

[jira] Created: (LUCENE-1864) bogus javadocs for FieldValueHitQuery.fillFields

bogus javadocs for FieldValueHitQuery.fillFields
------------------------------------------------

                 Key: LUCENE-1864
                 URL: https://issues.apache.org/jira/browse/LUCENE-1864
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Hoss Man
             Fix For: 2.9


FieldValueHitQuery.fillFields has javadocs that seem to be left over from a completely different method...

{code}
  /**
   * Given a FieldDoc object, stores the values used to sort the given document.
   * These values are not the raw values out of the index, but the internal
   * representation of them. This is so the given search hit can be collated by
   * a MultiSearcher with other search hits.
   * 
   * @param doc
   *          The FieldDoc to store sort values into.
   * @return The same FieldDoc passed in.
   * @see Searchable#search(Weight,Filter,int,Sort)
   */
  FieldDoc fillFields(final Entry entry) {
    final int n = comparators.length;
    final Comparable[] fields = new Comparable[n];
    for (int i = 0; i < n; ++i) {
      fields[i] = comparators[i].value(entry.slot);
    }
    //if (maxscore > 1.0f) doc.score /= maxscore;   // normalize scores
    return new FieldDoc(entry.docID, entry.score, fields);
  }

{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-1864) bogus javadocs for FieldValueHitQuery.fillFields

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reassigned LUCENE-1864:
------------------------------------------

    Assignee: Michael McCandless

> bogus javadocs for FieldValueHitQuery.fillFields
> ------------------------------------------------
>
>                 Key: LUCENE-1864
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1864
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>
> FieldValueHitQuery.fillFields has javadocs that seem to be left over from a completely different method...
> {code}
>   /**
>    * Given a FieldDoc object, stores the values used to sort the given document.
>    * These values are not the raw values out of the index, but the internal
>    * representation of them. This is so the given search hit can be collated by
>    * a MultiSearcher with other search hits.
>    * 
>    * @param doc
>    *          The FieldDoc to store sort values into.
>    * @return The same FieldDoc passed in.
>    * @see Searchable#search(Weight,Filter,int,Sort)
>    */
>   FieldDoc fillFields(final Entry entry) {
>     final int n = comparators.length;
>     final Comparable[] fields = new Comparable[n];
>     for (int i = 0; i < n; ++i) {
>       fields[i] = comparators[i].value(entry.slot);
>     }
>     //if (maxscore > 1.0f) doc.score /= maxscore;   // normalize scores
>     return new FieldDoc(entry.docID, entry.score, fields);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1864) bogus javadocs for FieldValueHitQuery.fillFields

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1864.
----------------------------------------

    Resolution: Fixed

> bogus javadocs for FieldValueHitQuery.fillFields
> ------------------------------------------------
>
>                 Key: LUCENE-1864
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1864
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>
> FieldValueHitQuery.fillFields has javadocs that seem to be left over from a completely different method...
> {code}
>   /**
>    * Given a FieldDoc object, stores the values used to sort the given document.
>    * These values are not the raw values out of the index, but the internal
>    * representation of them. This is so the given search hit can be collated by
>    * a MultiSearcher with other search hits.
>    * 
>    * @param doc
>    *          The FieldDoc to store sort values into.
>    * @return The same FieldDoc passed in.
>    * @see Searchable#search(Weight,Filter,int,Sort)
>    */
>   FieldDoc fillFields(final Entry entry) {
>     final int n = comparators.length;
>     final Comparable[] fields = new Comparable[n];
>     for (int i = 0; i < n; ++i) {
>       fields[i] = comparators[i].value(entry.slot);
>     }
>     //if (maxscore > 1.0f) doc.score /= maxscore;   // normalize scores
>     return new FieldDoc(entry.docID, entry.score, fields);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1864) bogus javadocs for FieldValueHitQuery.fillFields

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748439#action_12748439 ] 

Michael McCandless commented on LUCENE-1864:
--------------------------------------------

I'll fix this...

> bogus javadocs for FieldValueHitQuery.fillFields
> ------------------------------------------------
>
>                 Key: LUCENE-1864
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1864
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>
> FieldValueHitQuery.fillFields has javadocs that seem to be left over from a completely different method...
> {code}
>   /**
>    * Given a FieldDoc object, stores the values used to sort the given document.
>    * These values are not the raw values out of the index, but the internal
>    * representation of them. This is so the given search hit can be collated by
>    * a MultiSearcher with other search hits.
>    * 
>    * @param doc
>    *          The FieldDoc to store sort values into.
>    * @return The same FieldDoc passed in.
>    * @see Searchable#search(Weight,Filter,int,Sort)
>    */
>   FieldDoc fillFields(final Entry entry) {
>     final int n = comparators.length;
>     final Comparable[] fields = new Comparable[n];
>     for (int i = 0; i < n; ++i) {
>       fields[i] = comparators[i].value(entry.slot);
>     }
>     //if (maxscore > 1.0f) doc.score /= maxscore;   // normalize scores
>     return new FieldDoc(entry.docID, entry.score, fields);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org