You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by fe...@apache.org on 2021/11/25 02:29:07 UTC
[hadoop] branch branch-3.3 updated: HDFS-16350. Datanode start time should be set after RPC server starts successfully (#3711)
This is an automated email from the ASF dual-hosted git repository.
ferhui pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.3 by this push:
new a9125bb HDFS-16350. Datanode start time should be set after RPC server starts successfully (#3711)
a9125bb is described below
commit a9125bba24b1a93458c3e0cf95f5d233e29baa20
Author: Viraj Jasani <vj...@apache.org>
AuthorDate: Thu Nov 25 07:53:04 2021 +0530
HDFS-16350. Datanode start time should be set after RPC server starts successfully (#3711)
(cherry picked from commit cdc13e91b619159dc4bf185ad53b950bdf5de52a)
---
.../src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java | 3 ++-
.../org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
index bd57f40..f35534c 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
@@ -416,7 +416,7 @@ public class DataNode extends ReconfigurableBase
private ScheduledThreadPoolExecutor metricsLoggerTimer;
- private final long startTime = now();
+ private long startTime = 0;
/**
* Creates a dummy DataNode for testing purpose.
@@ -2681,6 +2681,7 @@ public class DataNode extends ReconfigurableBase
}
ipcServer.setTracer(tracer);
ipcServer.start();
+ startTime = now();
startPlugins(getConf());
}
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
index f72f1bc..ea43ccc 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
@@ -77,6 +77,7 @@ public class TestDataNodeMXBean extends SaslDataTransferTestCase {
Assert.assertEquals(datanode.getVersion(),version);
// get attribute "DNStartedTimeInMillis"
long startTime = (long) mbs.getAttribute(mxbeanName, "DNStartedTimeInMillis");
+ Assert.assertTrue("Datanode start time should not be 0", startTime > 0);
Assert.assertEquals(datanode.getDNStartedTimeInMillis(), startTime);
// get attribute "SotfwareVersion"
String softwareVersion =
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org