You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/08/04 13:42:26 UTC
Re: Review Request 23924: Fixed some more Coverity issues in
CitrixResourceBase.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 11:42 a.m.)
Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh Edukulla.
Changes
-------
Incorporated Murali Comments and added few more fixes from COverity scan.
Repository: cloudstack-git
Description
-------
Fixed some more Coverity reported issues in CitrixResourceBase.java.
Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180
Diffs (updated)
-----
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 775f5455
Diff: https://reviews.apache.org/r/23924/diff/
Testing (updated)
-------
Ran against marvin BVT.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 23924: Fixed some more Coverity issues in
CitrixResourceBase.java
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On Aug. 4, 2014, 11:59 a.m., Santhosh Edukulla wrote:
> > Ship It!
acffe5a..b73fe32 master -> master
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/#review49451
-----------------------------------------------------------
On Aug. 4, 2014, 11:56 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23924/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 11:56 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed some more Coverity reported issues in CitrixResourceBase.java.
>
> Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 775f5455
>
> Diff: https://reviews.apache.org/r/23924/diff/
>
>
> Testing
> -------
>
> Ran against marvin BVT.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23924: Fixed some more Coverity issues in
CitrixResourceBase.java
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/#review49451
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 4, 2014, 11:56 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23924/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 11:56 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed some more Coverity reported issues in CitrixResourceBase.java.
>
> Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 775f5455
>
> Diff: https://reviews.apache.org/r/23924/diff/
>
>
> Testing
> -------
>
> Ran against marvin BVT.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23924: Fixed some more Coverity issues in
CitrixResourceBase.java
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 11:56 a.m.)
Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh Edukulla.
Changes
-------
Incorporated Santhosh comments
Repository: cloudstack-git
Description
-------
Fixed some more Coverity reported issues in CitrixResourceBase.java.
Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180
Diffs (updated)
-----
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 775f5455
Diff: https://reviews.apache.org/r/23924/diff/
Testing
-------
Ran against marvin BVT.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 23924: Fixed some more Coverity issues in
CitrixResourceBase.java
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/#review49450
-----------------------------------------------------------
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/23924/#comment86527>
Please check if static is required here.
- Santhosh Edukulla
On Aug. 4, 2014, 11:42 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23924/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 11:42 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed some more Coverity reported issues in CitrixResourceBase.java.
>
> Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 775f5455
>
> Diff: https://reviews.apache.org/r/23924/diff/
>
>
> Testing
> -------
>
> Ran against marvin BVT.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>