You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "lovasoa (via GitHub)" <gi...@apache.org> on 2026/06/05 20:55:58 UTC
[PR] Escape quotes in national string display [datafusion-sqlparser-rs]
lovasoa opened a new pull request, #2365:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2365
## What changed
Escape single quotes when formatting `Value::NationalStringLiteral`.
## Why
`Value::SingleQuotedString` already escapes embedded single quotes before display, but `Value::NationalStringLiteral` wrote its payload directly as `N'{v}'`. That made valid SQL such as `N'Tu geres '';'' et ''"'' ?'` round-trip to invalid SQL.
## Validation
- `cargo test parse_literal_string`
- `cargo fmt --all -- --check`
- `cargo test --test sqlparser_common`
- `cargo test`
- `cargo clippy --all-targets --all-features -- -D warnings`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Microsoft sql server: Escape quotes in national string display [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio merged PR #2365:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Microsoft sql server: Escape quotes in national string display [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on PR #2365:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2365#issuecomment-4635518881
Hi @iffyio ! I think this needs to be prioritized, this bug is potentially exploitable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org