[GitHub] [druid] gianm commented on a diff in pull request #12908: Fixing overlord issued too many redirects

[GitBox <gi...@apache.org>]

gianm commented on code in PR #12908:
URL: https://github.com/apache/druid/pull/12908#discussion_r996193989


##########
server/src/main/java/org/apache/druid/rpc/ServiceClientImpl.java:
##########
@@ -200,7 +200,12 @@ public void onSuccess(@Nullable final Either<StringFullResponseHolder, FinalType
                         final String newUri = result.error().getResponse().headers().get("Location");
 
                         if (redirectCount >= MAX_REDIRECTS) {
-                          retVal.setException(new RpcException("Service [%s] issued too many redirects", serviceName));
+                          retVal.setException(new RpcException(
+                              "Service [%s] redirected too many times [%d] to invalid url %s",

Review Comment:
   The error message here isn't right: the url isn't known to be invalid at this point. It may very well be valid. It just exceeded the limit on number of redirects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org