[GitHub] [iotdb] THUMarkLau commented on a diff in pull request #5572: [IOTDB-2931] Remove access to metadata manager during compaction

[GitBox <gi...@apache.org>]

THUMarkLau commented on code in PR #5572:
URL: https://github.com/apache/iotdb/pull/5572#discussion_r882801828


##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java:
##########
@@ -386,11 +386,20 @@ public void restart() throws InterruptedException {
         this.taskExecutionPool.shutdownNow();
         this.taskExecutionPool.awaitTermination(Long.MAX_VALUE, TimeUnit.MILLISECONDS);
       }
+      if (this.subCompactionTaskExecutionPool != null) {
+        subCompactionTaskExecutionPool.shutdownNow();
+        this.subCompactionTaskExecutionPool.awaitTermination(Long.MAX_VALUE, TimeUnit.MILLISECONDS);
+      }

Review Comment:
   resolve



##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/utils/AlignedSeriesCompactionExecutor.java:
##########
@@ -99,9 +105,18 @@ private List<IMeasurementSchema> collectSchemaFromAlignedChunkMetadataList(
           if (chunkMetadata == null) {
             continue;
           }
+          if (measurementSet.contains(chunkMetadata.getMeasurementUid())) {
+            continue;
+          }
+          measurementSet.add(chunkMetadata.getMeasurementUid());
+          Chunk chunk = reader.readMemChunk((ChunkMetadata) chunkMetadata);
+          ChunkHeader header = chunk.getHeader();
           schemaSet.add(
               new MeasurementSchema(
-                  chunkMetadata.getMeasurementUid(), chunkMetadata.getDataType()));
+                  header.getMeasurementID(),
+                  header.getDataType(),
+                  header.getEncodingType(),
+                  header.getCompressionType()));

Review Comment:
   resolve



##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/performer/impl/ReadPointCompactionPerformer.java:
##########
@@ -146,19 +153,9 @@ private void compactAlignedSeries(
     MultiTsFileDeviceIterator.AlignedMeasurementIterator alignedMeasurementIterator =
         deviceIterator.iterateAlignedSeries(device);
     Set<String> allMeasurements = alignedMeasurementIterator.getAllMeasurements();
-    List<IMeasurementSchema> measurementSchemas = new ArrayList<>();
-    for (String measurement : allMeasurements) {
-      try {
-        if (IoTDBDescriptor.getInstance().getConfig().isEnableIDTable()) {
-          measurementSchemas.add(IDTableManager.getInstance().getSeriesSchema(device, measurement));
-        } else {
-          measurementSchemas.add(
-              IoTDB.schemaProcessor.getSeriesSchema(new PartialPath(device, measurement)));
-        }
-      } catch (PathNotExistException e) {
-        LOGGER.info("A deleted path is skipped: {}", e.getMessage());
-      }
-    }
+    ConcurrentHashMap<String, MeasurementSchema> schemaMap =
+        getMeasurementSchema(device, allMeasurements);
+    List<IMeasurementSchema> measurementSchemas = new ArrayList<>(schemaMap.values());

Review Comment:
   resolve



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org