You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Kalle Korhonen (JIRA)" <ji...@apache.org> on 2009/08/26 05:49:59 UTC
[jira] Created: (SHIRO-91) Tests for getRememberedPrincipals and
getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are
disabled
Tests for getRememberedPrincipals and getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are disabled
---------------------------------------------------------------------------------------------------------------------
Key: SHIRO-91
URL: https://issues.apache.org/jira/browse/SHIRO-91
Project: Shiro
Issue Type: Test
Components: Web
Affects Versions: 0.9
Environment: any
Reporter: Kalle Korhonen
Fix For: 1.0
@Test annotation for getRememberedPrincipals and getRememberedPrincipalsDecryptionError tests in WebRememberMeManagerTest is commented out. If re-enabled, the tests won't succeed. RememberMe doesn't seem to be working anymore after Subject was refactored and SubjectBuilder introduced (I'll look into it more and probably open a different issue for that one - but these tests need to be enabled to serve as regression testing suite).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SHIRO-91) Tests for getRememberedPrincipals
and getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are
disabled
Posted by Les Hazlewood <lh...@apache.org>.
Oops - I forgot about this. That's all I needed - no need to open an
issue. Thanks!
On Thu, Aug 27, 2009 at 2:05 PM, Kalle Korhonen (JIRA)<ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/SHIRO-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748480#action_12748480 ]
>
> Kalle Korhonen commented on SHIRO-91:
> -------------------------------------
>
> As mentioned in my email, the issue with rememberMe is:
> ---
> I see that Subject.login() now works again, but RememberMe is broken,
> because the new DefaultSecurityManager.createSubject(Map context)
> doesn't call getRememberedIdentity at any point. Compare to the old
> createSubject() that does:
> if (session != null) {
> if (session.getAttribute(SessionSubjectBinder.PRINCIPALS_SESSION_KEY)
> == null) {
> remembered = getRememberedIdentity();
> }
> }
>
> Should I open an issue or are you still working on it to complete this
> refactoring?
> ---
> Compare the createSubject() operations in DefaultSecurityManager - rememberMeManager is never invoked in the new one.
>
>> Tests for getRememberedPrincipals and getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are disabled
>> ---------------------------------------------------------------------------------------------------------------------
>>
>> Key: SHIRO-91
>> URL: https://issues.apache.org/jira/browse/SHIRO-91
>> Project: Shiro
>> Issue Type: Test
>> Components: Web
>> Affects Versions: 0.9
>> Environment: any
>> Reporter: Kalle Korhonen
>> Fix For: 1.0
>>
>>
>> @Test annotation for getRememberedPrincipals and getRememberedPrincipalsDecryptionError tests in WebRememberMeManagerTest is commented out. If re-enabled, the tests won't succeed. RememberMe doesn't seem to be working anymore after Subject was refactored and SubjectBuilder introduced (I'll look into it more and probably open a different issue for that one - but these tests need to be enabled to serve as regression testing suite).
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (SHIRO-91) Tests for getRememberedPrincipals and
getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are
disabled
Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748480#action_12748480 ]
Kalle Korhonen commented on SHIRO-91:
-------------------------------------
As mentioned in my email, the issue with rememberMe is:
---
I see that Subject.login() now works again, but RememberMe is broken,
because the new DefaultSecurityManager.createSubject(Map context)
doesn't call getRememberedIdentity at any point. Compare to the old
createSubject() that does:
if (session != null) {
if (session.getAttribute(SessionSubjectBinder.PRINCIPALS_SESSION_KEY)
== null) {
remembered = getRememberedIdentity();
}
}
Should I open an issue or are you still working on it to complete this
refactoring?
---
Compare the createSubject() operations in DefaultSecurityManager - rememberMeManager is never invoked in the new one.
> Tests for getRememberedPrincipals and getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are disabled
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-91
> URL: https://issues.apache.org/jira/browse/SHIRO-91
> Project: Shiro
> Issue Type: Test
> Components: Web
> Affects Versions: 0.9
> Environment: any
> Reporter: Kalle Korhonen
> Fix For: 1.0
>
>
> @Test annotation for getRememberedPrincipals and getRememberedPrincipalsDecryptionError tests in WebRememberMeManagerTest is commented out. If re-enabled, the tests won't succeed. RememberMe doesn't seem to be working anymore after Subject was refactored and SubjectBuilder introduced (I'll look into it more and probably open a different issue for that one - but these tests need to be enabled to serve as regression testing suite).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHIRO-91) Tests for getRememberedPrincipals and
getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are
disabled
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747929#action_12747929 ]
Les Hazlewood commented on SHIRO-91:
------------------------------------
Yep, those tests are purposely commented out until I can address the issue today - I just wanted to make sure they wouldn't fail the build when I needed to get the ServletRequest exceptions fixes committed. But I still appreciate this issue being opened since I can now associate commit messages specifically for RememberMe :) Thanks!
> Tests for getRememberedPrincipals and getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are disabled
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-91
> URL: https://issues.apache.org/jira/browse/SHIRO-91
> Project: Shiro
> Issue Type: Test
> Components: Web
> Affects Versions: 0.9
> Environment: any
> Reporter: Kalle Korhonen
> Fix For: 1.0
>
>
> @Test annotation for getRememberedPrincipals and getRememberedPrincipalsDecryptionError tests in WebRememberMeManagerTest is commented out. If re-enabled, the tests won't succeed. RememberMe doesn't seem to be working anymore after Subject was refactored and SubjectBuilder introduced (I'll look into it more and probably open a different issue for that one - but these tests need to be enabled to serve as regression testing suite).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHIRO-91) Tests for getRememberedPrincipals and
getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are
disabled
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Les Hazlewood resolved SHIRO-91.
--------------------------------
Resolution: Fixed
added back in the rememberMe call in the new resolvePrincipals method in DefaultSecurityManager
> Tests for getRememberedPrincipals and getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are disabled
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-91
> URL: https://issues.apache.org/jira/browse/SHIRO-91
> Project: Shiro
> Issue Type: Test
> Components: Web
> Affects Versions: 0.9
> Environment: any
> Reporter: Kalle Korhonen
> Fix For: 1.0
>
>
> @Test annotation for getRememberedPrincipals and getRememberedPrincipalsDecryptionError tests in WebRememberMeManagerTest is commented out. If re-enabled, the tests won't succeed. RememberMe doesn't seem to be working anymore after Subject was refactored and SubjectBuilder introduced (I'll look into it more and probably open a different issue for that one - but these tests need to be enabled to serve as regression testing suite).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHIRO-91) Tests for getRememberedPrincipals and
getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are
disabled
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748450#action_12748450 ]
Les Hazlewood commented on SHIRO-91:
------------------------------------
I just re-enabled those tests but the fixes were superficial - ensuring a mock call was recognized. But no underlying logic was changed.
Would you be able to create a test case that re-creates the issue? I'll keep trying on my end, but I don't see anything at the moment. The SubjectBuilder changes also didn't affect any of the WebRememberMeManager logic. The only thing a WebRememberMeManager needs to function is a thread-bound ServletRequest/ServletResponse pair, and those were re-enabled 2 days ago - I can't think of what else would cause this to fail at the moment. Any other additional info would be appreciated.
> Tests for getRememberedPrincipals and getRememberedPrincipalsDecryptionError in WebRememberMeManagerTest are disabled
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-91
> URL: https://issues.apache.org/jira/browse/SHIRO-91
> Project: Shiro
> Issue Type: Test
> Components: Web
> Affects Versions: 0.9
> Environment: any
> Reporter: Kalle Korhonen
> Fix For: 1.0
>
>
> @Test annotation for getRememberedPrincipals and getRememberedPrincipalsDecryptionError tests in WebRememberMeManagerTest is commented out. If re-enabled, the tests won't succeed. RememberMe doesn't seem to be working anymore after Subject was refactored and SubjectBuilder introduced (I'll look into it more and probably open a different issue for that one - but these tests need to be enabled to serve as regression testing suite).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.