You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by doychin <gi...@git.apache.org> on 2019/01/02 12:33:14 UTC
[GitHub] tomee pull request #345: Incorrect artifact version in the test
GitHub user doychin opened a pull request:
https://github.com/apache/tomee/pull/345
Incorrect artifact version in the test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/doychin/tomee incorrect-artifact-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomee/pull/345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #345
----
commit f3588cb7dd23f02a0283a2575a58b6ef22e67d61
Author: Doychin Bondzhev <do...@...>
Date: 2019-01-02T12:32:32Z
Incorrect artifact version in the test
----
---
[GitHub] tomee pull request #345: Incorrect artifact version in the test
Posted by brunobat <gi...@git.apache.org>.
Github user brunobat commented on a diff in the pull request:
https://github.com/apache/tomee/pull/345#discussion_r244945167
--- Diff: examples/simple-ear/moviefun-functional-tests/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java ---
@@ -37,7 +37,7 @@
@Deployment
public static EnterpriseArchive createDeployment() {
- final EnterpriseArchive enterpriseArchive = Maven.resolver().resolve("org.superbiz:moviefun-ear:ear:7.0.6-SNAPSHOT")
+ final EnterpriseArchive enterpriseArchive = Maven.resolver().resolve("org.superbiz:moviefun-ear:ear:8.0.0-SNAPSHOT")
--- End diff --
This can also be happening elsewhere...
---
[GitHub] tomee pull request #345: Incorrect artifact version in the test
Posted by doychin <gi...@git.apache.org>.
Github user doychin commented on a diff in the pull request:
https://github.com/apache/tomee/pull/345#discussion_r244944073
--- Diff: examples/simple-ear/moviefun-functional-tests/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java ---
@@ -37,7 +37,7 @@
@Deployment
public static EnterpriseArchive createDeployment() {
- final EnterpriseArchive enterpriseArchive = Maven.resolver().resolve("org.superbiz:moviefun-ear:ear:7.0.6-SNAPSHOT")
+ final EnterpriseArchive enterpriseArchive = Maven.resolver().resolve("org.superbiz:moviefun-ear:ear:8.0.0-SNAPSHOT")
--- End diff --
I'll see if I can do this.
---
[GitHub] tomee pull request #345: Incorrect artifact version in the test
Posted by brunobat <gi...@git.apache.org>.
Github user brunobat commented on a diff in the pull request:
https://github.com/apache/tomee/pull/345#discussion_r244943871
--- Diff: examples/simple-ear/moviefun-functional-tests/src/test/java/org/superbiz/moviefun/MoviesArquillianHtmlUnitTest.java ---
@@ -37,7 +37,7 @@
@Deployment
public static EnterpriseArchive createDeployment() {
- final EnterpriseArchive enterpriseArchive = Maven.resolver().resolve("org.superbiz:moviefun-ear:ear:7.0.6-SNAPSHOT")
+ final EnterpriseArchive enterpriseArchive = Maven.resolver().resolve("org.superbiz:moviefun-ear:ear:8.0.0-SNAPSHOT")
--- End diff --
I wonder if we could get that version value from the project version. That would fix the issue permanently.
---