[GitHub] [spark] zhengruifeng commented on a diff in pull request #40355: [SPARK-42604][CONNECT] Implement functions.typedlit

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #40355:
URL: https://github.com/apache/spark/pull/40355#discussion_r1133565363


##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -195,6 +197,18 @@ message Expression {
       DataType element_type = 1;
       repeated Literal elements = 2;
     }
+
+    message Map {
+      DataType keyType = 1;
+      DataType valueType = 2;

Review Comment:
   ```suggestion
         DataType key_type = 1;
         DataType value_type = 2;
   ```



##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -195,6 +197,18 @@ message Expression {
       DataType element_type = 1;
       repeated Literal elements = 2;
     }
+
+    message Map {
+      DataType keyType = 1;
+      DataType valueType = 2;
+      repeated Literal keys = 3;
+      repeated Literal values = 4;
+    }
+
+    message Struct {
+      DataType structType = 1;

Review Comment:
   ```suggestion
         DataType struct_type = 1;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org