You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Sahoo (JIRA)" <ji...@apache.org> on 2009/03/12 11:34:51 UTC

[jira] Created: (FELIX-983) Allow property substitution in config file

Allow property substitution in config file
------------------------------------------

                 Key: FELIX-983
                 URL: https://issues.apache.org/jira/browse/FELIX-983
             Project: Felix
          Issue Type: Improvement
          Components: File Install
    Affects Versions: fileinstall-0.9.2
         Environment: generic
            Reporter: Sahoo
             Fix For: fileinstall-0.9.2


Just like Felix's system.properties file and config.properties file allow property substition, FileInstall bundle should allow the same for config files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Resolved: (FELIX-983) Allow property substitution in config file

Posted by Filippo Diotalevi <fi...@gmail.com>.
On Wed, Mar 25, 2009 at 7:20 AM, Richard S. Hall (JIRA) <ji...@apache.org> wrote:
>
> Richard S. Hall resolved FELIX-983.
> -----------------------------------
>
>    Resolution: Fixed
>      Assignee: Richard S. Hall
>
> I applied this patch and deployed a new snapshot. Please close this bug, thanks.
> Thanks for the patch Filippo.

Thanks Richard. Can you please have a look also at FELIX-998 for
inclusion in the next fileinstall release?
It's a very simple patch, but it would make fileinstall configurable
with the webconsole..

Many thanks,
-- 
Filippo Diotalevi

[jira] Closed: (FELIX-983) Allow property substitution in config file

Posted by "Sahoo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sahoo closed FELIX-983.
-----------------------


Closing the issue as the patch has been applied.

> Allow property substitution in config file
> ------------------------------------------
>
>                 Key: FELIX-983
>                 URL: https://issues.apache.org/jira/browse/FELIX-983
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-0.9.2
>         Environment: generic
>            Reporter: Sahoo
>            Assignee: Richard S. Hall
>             Fix For: fileinstall-0.9.2
>
>         Attachments: FELIX-983.patch
>
>
> Just like Felix's system.properties file and config.properties file allow property substition, FileInstall bundle should allow the same for config files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-983) Allow property substitution in config file

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall resolved FELIX-983.
-----------------------------------

    Resolution: Fixed
      Assignee: Richard S. Hall

I applied this patch and deployed a new snapshot. Please close this bug, thanks.

Thanks for the patch Filippo.

> Allow property substitution in config file
> ------------------------------------------
>
>                 Key: FELIX-983
>                 URL: https://issues.apache.org/jira/browse/FELIX-983
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-0.9.2
>         Environment: generic
>            Reporter: Sahoo
>            Assignee: Richard S. Hall
>             Fix For: fileinstall-0.9.2
>
>         Attachments: FELIX-983.patch
>
>
> Just like Felix's system.properties file and config.properties file allow property substition, FileInstall bundle should allow the same for config files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-983) Allow property substitution in config file

Posted by "Sahoo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688999#action_12688999 ] 

Sahoo commented on FELIX-983:
-----------------------------

I tried out the patch in my local workspace and it works. Thanks Filippo for quick work around. Can anyone now apply the same? 

> Allow property substitution in config file
> ------------------------------------------
>
>                 Key: FELIX-983
>                 URL: https://issues.apache.org/jira/browse/FELIX-983
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-0.9.2
>         Environment: generic
>            Reporter: Sahoo
>             Fix For: fileinstall-0.9.2
>
>         Attachments: FELIX-983.patch
>
>
> Just like Felix's system.properties file and config.properties file allow property substition, FileInstall bundle should allow the same for config files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-983) Allow property substitution in config file

Posted by "Filippo Diotalevi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Filippo Diotalevi updated FELIX-983:
------------------------------------

    Attachment: FELIX-983.patch

The patch performs property sostitution in the updated(..) method of FileInstall.

To do property sostitution, I duplicated the code of org.apache.felix.framework.util.Util.substVars... so that the bundle can run on other osgi containers as well (being independent by Felix).

> Allow property substitution in config file
> ------------------------------------------
>
>                 Key: FELIX-983
>                 URL: https://issues.apache.org/jira/browse/FELIX-983
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-0.9.2
>         Environment: generic
>            Reporter: Sahoo
>             Fix For: fileinstall-0.9.2
>
>         Attachments: FELIX-983.patch
>
>
> Just like Felix's system.properties file and config.properties file allow property substition, FileInstall bundle should allow the same for config files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.