You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/17 02:24:29 UTC
[GitHub] [ozone] smengcl opened a new pull request, #3316: HDDS-6593. Bump node to v16.14.2 for Recon
smengcl opened a new pull request, #3316:
URL: https://github.com/apache/ozone/pull/3316
## What changes were proposed in this pull request?
Bump Recon's node to latest LTS: https://nodejs.org/en/download/
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6593
## How was this patch tested?
- [x] Pass compilation
- [x] Recon boots up fine in docker compose cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #3316: HDDS-6593. Bump node to v16.14.2 for Recon
Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #3316:
URL: https://github.com/apache/ozone/pull/3316#issuecomment-1101696566
Thanks @ayushtkn and @avijayanhwx for the review! Thanks @ayushtkn for merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a diff in pull request #3316: HDDS-6593. Bump node to v16.14.2 for Recon
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on code in PR #3316:
URL: https://github.com/apache/ozone/pull/3316#discussion_r851710923
##########
hadoop-ozone/recon/pom.xml:
##########
@@ -103,7 +103,7 @@
<goal>install-node-and-npm</goal>
</goals>
<configuration>
- <nodeVersion>v16.2.0</nodeVersion>
+ <nodeVersion>v16.14.2</nodeVersion>
Review Comment:
Makes sense, thnx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn merged pull request #3316: HDDS-6593. Bump node to v16.14.2 for Recon
Posted by GitBox <gi...@apache.org>.
ayushtkn merged PR #3316:
URL: https://github.com/apache/ozone/pull/3316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #3316: HDDS-6593. Bump node to v16.14.2 for Recon
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on PR #3316:
URL: https://github.com/apache/ozone/pull/3316#issuecomment-1101153016
Thanx @smengcl for the contribution and @avijayanhwx for the review!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a diff in pull request #3316: HDDS-6593. Bump node to v16.14.2 for Recon
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on code in PR #3316:
URL: https://github.com/apache/ozone/pull/3316#discussion_r851708436
##########
hadoop-ozone/recon/pom.xml:
##########
@@ -103,7 +103,7 @@
<goal>install-node-and-npm</goal>
</goals>
<configuration>
- <nodeVersion>v16.2.0</nodeVersion>
+ <nodeVersion>v16.14.2</nodeVersion>
Review Comment:
we want to stick to v16 release line only? Guess [17.7.2](https://www.npmjs.com/package/node/v/17.7.2) is also there. Just wanted to confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3316: HDDS-6593. Bump node to v16.14.2 for Recon
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3316:
URL: https://github.com/apache/ozone/pull/3316#discussion_r851709468
##########
hadoop-ozone/recon/pom.xml:
##########
@@ -103,7 +103,7 @@
<goal>install-node-and-npm</goal>
</goals>
<configuration>
- <nodeVersion>v16.2.0</nodeVersion>
+ <nodeVersion>v16.14.2</nodeVersion>
Review Comment:
Yup. LTS v16 is the way to go, supported till 2024-04-30. While v17 EoL is 2022-06-01. https://nodejs.org/en/about/releases/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org