You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/14 11:52:35 UTC
[GitHub] [kafka] divijvaidya opened a new pull request, #12989: KAFKA-14469: Fix remote tiered related topic configuration
divijvaidya opened a new pull request, #12989:
URL: https://github.com/apache/kafka/pull/12989
We have 3 tiered storage configuration keys that are not adhering to KIP-405 specification. KIP-405 has ".log" in the keys.
KIP-405: https://cwiki.apache.org/confluence/display/KAFKA/KIP-405%3A+Kafka+Tiered+Storage#KIP405:KafkaTieredStorage-Configs.1
Kafka 3.3: https://github.com/apache/kafka/blob/3.3/clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java#L78-L90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya closed pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration
Posted by GitBox <gi...@apache.org>.
divijvaidya closed pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration
URL: https://github.com/apache/kafka/pull/12989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd commented on a diff in pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration
Posted by GitBox <gi...@apache.org>.
satishd commented on code in PR #12989:
URL: https://github.com/apache/kafka/pull/12989#discussion_r1049118373
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -75,16 +75,16 @@ public class TopicConfig {
"\"delete\" retention policy. This represents an SLA on how soon consumers must read " +
"their data. If set to -1, no time limit is applied.";
- public static final String REMOTE_LOG_STORAGE_ENABLE_CONFIG = "remote.storage.enable";
+ public static final String REMOTE_LOG_STORAGE_ENABLE_CONFIG = "remote.log.storage.enable";
Review Comment:
Topic configurations do not include "log". That is why we decided not to have for the newly introduced configs. Same for other configs mentioned in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12989:
URL: https://github.com/apache/kafka/pull/12989#issuecomment-1356016457
Hmm, the naming scheme is pretty confusing. If we made changes to the KIP, we should send an email to the mailing list with a summary so people can provide feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12989:
URL: https://github.com/apache/kafka/pull/12989#issuecomment-1352436760
Thoughts @satishd?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #12989:
URL: https://github.com/apache/kafka/pull/12989#issuecomment-1352777373
Thanks @satishd. I will discard this PR in that case. When you get a chance, please update the KIP to make it consistent with the above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org