You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "anita kulshreshtha (JIRA)" <de...@geronimo.apache.org> on 2005/09/30 23:56:48 UTC
[jira] Created: (GERONIMO-1035) tomcat integration should wrap each servlet indiviudally
tomcat integration should wrap each servlet indiviudally
---------------------------------------------------------
Key: GERONIMO-1035
URL: http://issues.apache.org/jira/browse/GERONIMO-1035
Project: Geronimo
Type: New Feature
Components: Tomcat
Environment: All
Reporter: anita kulshreshtha
TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12424106 ]
Anita Kulshreshtha commented on GERONIMO-1035:
----------------------------------------------
Donald, tomcat provides statistics for each connector similar to jetty. For more details please see:
http://issues.apache.org/jira/browse/GERONIMO-1293#action_12360139
These can be displayed on the connector page.
Tomcat does not provide container wide statistics. I do not know if computing these by aggregating per
connector statistics provides any benifits.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Jeff Genender
> Fix For: 1.2
>
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, pom.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: management.patch
tomcat-builder.patch
tomcat.patch
patches updated to rev 391200.
1. tomcat.patch
2. tomcat-builder.patch
3. management.patch
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Security: public(Regular issues)
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.2
> Attachments: application.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "anita kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
anita kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: tomcat.patch
tomcat-builder.patch
management.patch
This patch creates servlets Gbeans. Currently Gbeans only provide the stats. It includes patches for G-1293.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: anita kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: management.patch, tomcat-builder.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: tomcat.patch
tomcat-builder.patch
management.patch
These patches are built against fresh copy of rev 379835. The code has been reformatted to adhere to coding conventions.
A separate patch will be submitted to deal with G-1585.
These can be applied either now or after the resolution of G-1649 (MDBs do not start)
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: applications.patch
applications.patch contains the webapp to view tomcat internals.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Security: public(Regular issues)
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.2
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "anita kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
anita kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: tomcat-builder.patch
Added webservice servlet Gbeans
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: anita kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: tomcat-builder.patch
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12423211 ]
Anita Kulshreshtha commented on GERONIMO-1035:
----------------------------------------------
Thanks Donald for taking interest in this! Yes, this was for the old trunk.. I need to redo this for the new trunk.
It was a long time ago.. I will have to take a look at the code to answer your questions. Once the M2 build issues are resolved,
I will be able to work on this patch.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Jeff Genender
> Fix For: 1.2
>
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, pom.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: tomcat.patch
tomcat-builder.patch
Updated the patches, built against trunk (rev 376797). These patches work with 5.5.12!
1. tomcat-builder.patch -
The tomcat-module-builder.patch and TomcatServletHolder from tomcat.patch is required for this issue.
Added unit test for G-1585 (securing with /*). This test will fail unless change from G-1585 is included.
2. tomcat.patch -
The tomcat.patch is needed for stats and should be applied with management.patch.
3. stats.zip -
- stats.zip has a JMXPROXY servlet. I think it is a good thing to have in the code base. It lets you peek into tomcat MBeans. We might need this when we start worrying about the performance issues of the cluster. It is a modified version of the one used by tomcat Manager application.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12423092 ]
Donald Woods commented on GERONIMO-1035:
----------------------------------------
Anita, how do these Tomcat stats relate to those being provided by a Geronimo server using Jetty?
It seems that the provided patches don't extend the same stat classes like -
org.apache.geronimo.management.geronimo.stats.WebContainerStats
that the Jetty implementation does.
Also, does your patches provided the needed stat values for the current WebManagerPortlet.java code that works for Jetty?
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Jeff Genender
> Fix For: 1.2
>
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, pom.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha closed GERONIMO-1035.
----------------------------------------
Fix Version/s: 2.0
(was: 1.2)
Resolution: Later
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Jeff Genender
> Fix For: 2.0
>
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, pom.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (GERONIMO-1035) tomcat integration should wrap each servlet indiviudally
Posted by anita kulshreshtha <a_...@yahoo.com>.
I am looking into it. Will get get back to you
soon.
Thanks
Anita
--- "Jeff Genender (JIRA)" <de...@geronimo.apache.org>
wrote:
> [
>
http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12367032
> ]
>
> Jeff Genender commented on GERONIMO-1035:
> -----------------------------------------
>
> The management patch fails on the compile...looks
> like its missing something?
>
> java:compile:
> <depend closure="false" srcdir="1.4" dump="false"
>
destdir="/Users/powerbook/Projects/geronimo/modules/management/target/classes"></depend>
> [echo] Compiling to
>
/Users/powerbook/Projects/geronimo/modules/management/target/classes
> [javac] Compiling 3 source files to
>
/Users/powerbook/Projects/geronimo/modules/management/target/classes
> [javac]
>
/Users/powerbook/Projects/geronimo/modules/management/src/java/org/apache/geronimo/management/stats/WebModuleStatsImpl.java:19:
> cannot resolve symbol
> [javac] symbol : class WebModuleStats
> [javac] location: package stats
> [javac] import
>
org.apache.geronimo.management.geronimo.stats.WebModuleStats;
> [javac]
> ^
> [javac]
>
/Users/powerbook/Projects/geronimo/modules/management/src/java/org/apache/geronimo/management/stats/WebModuleStatsImpl.java:31:
> cannot resolve symbol
> [javac] symbol : class WebModuleStats
> [javac] location: class
>
org.apache.geronimo.management.stats.WebModuleStatsImpl
> [javac] public class WebModuleStatsImpl extends
> StatsImpl implements WebModuleStats {
> [javac]
> ^
> [javac] 2 errors
>
>
> > tomcat integration should wrap each servlet
> indiviudally
> >
>
--------------------------------------------------------
> >
> > Key: GERONIMO-1035
> > URL:
> http://issues.apache.org/jira/browse/GERONIMO-1035
> > Project: Geronimo
> > Type: New Feature
> > Components: Tomcat
> > Versions: 1.0-M5
> > Environment: All
> > Reporter: Anita Kulshreshtha
> > Assignee: Jeff Genender
> > Fix For: 1.1
> > Attachments: geronimo-stats-1.1-SNAPSHOT.war,
> management.patch, stats.zip, tomcat-builder.patch,
> tomcat-builder.patch, tomcat-builder.patch,
> tomcat-builder.patch, tomcat.patch, tomcat.patch
> >
> > TomcatModuleBuilder should wrap each servlet
> specified in the deployment descriptor individually.
> This is needed by JSR-77 and for gathering tomcat
> internal statistics.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of
> the administrators:
>
>
http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12367032 ]
Jeff Genender commented on GERONIMO-1035:
-----------------------------------------
The management patch fails on the compile...looks like its missing something?
java:compile:
<depend closure="false" srcdir="1.4" dump="false" destdir="/Users/powerbook/Projects/geronimo/modules/management/target/classes"></depend> [echo] Compiling to /Users/powerbook/Projects/geronimo/modules/management/target/classes
[javac] Compiling 3 source files to /Users/powerbook/Projects/geronimo/modules/management/target/classes
[javac] /Users/powerbook/Projects/geronimo/modules/management/src/java/org/apache/geronimo/management/stats/WebModuleStatsImpl.java:19: cannot resolve symbol
[javac] symbol : class WebModuleStats
[javac] location: package stats
[javac] import org.apache.geronimo.management.geronimo.stats.WebModuleStats;
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/management/src/java/org/apache/geronimo/management/stats/WebModuleStatsImpl.java:31: cannot resolve symbol
[javac] symbol : class WebModuleStats
[javac] location: class org.apache.geronimo.management.stats.WebModuleStatsImpl
[javac] public class WebModuleStatsImpl extends StatsImpl implements WebModuleStats {
[javac] ^
[javac] 2 errors
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: tomcat-builder.patch
Sorry for the confusion. I included the test thinking that G-1585 can also be resolved at the same time. Since G-1585 affects
both Jetty and tomcat, it will be best to deal with it separately. A similar test will have to be added to Jetty. I have disabled the
test in this patch for now. I am working on reformatting everything and will submit a clean version of everything either tonight
or tomorrow.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12366966 ]
Anita Kulshreshtha commented on GERONIMO-1035:
----------------------------------------------
Thanks Jeff. As noted in the first comment, this is the first step towards adding servlets to tomcat via GBeans. The tomcat deployer (not TMB) still adds the servlets and this code wraps them in GBeans. This code is sufficient for JSR-77. Adding servlets to tomcat via GBeans requires a major change of GeronimoStandardContext, other *Context and the TomcatContainer (createContext(..)). I am not sure if it will provide additional benefits. I have not come across any issues with our current implementation. There may (or may not) be some issues later when we try to merge the thread pools. As we discussed before, shutting off parsing of web.xml is not very straighforward. We will have to duplicate most of the functionality of ContextConfig. I would be happy to work on this, if you think it is needed.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: applications.patch
There was a bug in TortoiseSVN. Earlier it silently ignored adding files to the patches that were in a new folder added via svn 'add'.
The new version still does not allow it. Hence the tomcat.patch and applications.patch have been created the old fashion way, i.e the
command line.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: application.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12366950 ]
Jeff Genender commented on GERONIMO-1035:
-----------------------------------------
Hi Anita. Cool code...and a lot of it looks good. But a few questions ... could you please explain where you shut off the web.xml parsing from Tomcat? It would appear that you are adding the servlets as well as Tomcat, so you would have double the servlet based objects created. I did not see where the Digester was shut off or where you grabbed the servlet creation instead of Tomcat. If you could show me where this is done, I can proceed forward in the testing of this code and integrating it.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12367050 ]
Jeff Genender commented on GERONIMO-1035:
-----------------------------------------
I have to go back to the management patch again...One more swag on the management.patch. It was not built form the top of the module, it was built from the src directory.
Now the management and tomcat components build. The final problem is the tomcat-builder patch. It fails the TomcatModuleBuilderTest. The results of the test are below. Please rebuild your patches and apply them to a fresh check out. Please be sure they all compile and all unit tests pass. Thanks
Here is the result of the failed unit test in the Tomcat Builder :
Testcase: testDeployWar3(org.apache.geronimo.tomcat.deployment.TomcatModuleBuilderTest): Caused an ERROR
Unable to initialize webapp GBean
org.apache.geronimo.common.DeploymentException: Unable to initialize webapp GBean
at org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:404)
at org.apache.geronimo.tomcat.deployment.TomcatModuleBuilderTest.deployWar(TomcatModuleBuilderTest.java:192)
at org.apache.geronimo.tomcat.deployment.TomcatModuleBuilderTest.testDeployWar3(TomcatModuleBuilderTest.java:148)
Caused by: java.lang.IllegalArgumentException: Qualifier patterns in the URLPatternSpec cannot match the first URLPattern
at javax.security.jacc.URLPatternSpec.<init>(URLPatternSpec.java:54)
at javax.security.jacc.WebResourcePermission.<init>(WebResourcePermission.java:54)
at org.apache.geronimo.tomcat.deployment.AbstractTomcatModuleBuilder.buildSpecSecurityConfig(AbstractTomcatModuleBuilder.java:677)
at org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:377)
... 17 more
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each servlet indiviudally
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Aaron Mulder updated GERONIMO-1035:
-----------------------------------
Fix Version: 1.1
Version: 1.0-M5
Assign To: Jeff Genender
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: anita kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12450730 ]
Anita Kulshreshtha commented on GERONIMO-1035:
----------------------------------------------
I will be attaching the statistics pathces to GERONIMO-1293. I am working on a more efficient implementation
of J2EEManagedObject Servlet and will create new issues.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Jeff Genender
> Fix For: 1.2
>
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, pom.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12423127 ]
Donald Woods commented on GERONIMO-1035:
----------------------------------------
Also, the AbstractTomcatModuleBuilder.java part of the tomcat-builder.patch will not compile.
Seems that the whole patch needs to be reworked, due to some Tomcat and Tomcat-Builder changes that went into 1.1 after your initial work....
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Jeff Genender
> Fix For: 1.2
>
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, pom.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "anita kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
anita kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: stats.zip
geronimo-stats-1.1-SNAPSHOT.war
This patch is for viewing the stats and is exactly same as for G-1293
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: anita kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: application.patch
Here is the list -
1. tomcat.patch
2. tomcat-builder.patch
3. management.patch
4. application.patch - An app to view tomcat internals and geronimo internals (jsr77 style).
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: application.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12367066 ]
Jeff Genender commented on GERONIMO-1035:
-----------------------------------------
Yes, please do not include broken Unit tests. All Unit tests have to pass, or it breaks the build. As I stated before, please be sure you can apply your patches and completely build Geronimo, and it all must compile and all the tests must pass before we can even begin to think about using this code. Your changes in code can impact other modules, so this is very important that this works.
If the broken test is testing (/*) issues, then I would suggest that you leave the unit test but test that the proper error was thrown. That would be a valid test case for your change. Also the xml files need to be cleaned up as well. Please format them appropriately and supply a new patch for the Tomcat builder, so we can proceed forward.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "anita kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12364170 ]
anita kulshreshtha commented on GERONIMO-1035:
----------------------------------------------
Added servletStats. The latest patches are attached to G-1293. The patch names reflects the module name. Here is the list :
tomcat.patch
tomcat-builder.patch
management.patch
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: anita kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12367063 ]
Anita Kulshreshtha commented on GERONIMO-1035:
----------------------------------------------
As noted in the comment on 12Feb, item 1, a test for G-1585 ("/*" in security-constraint) is included. This test will fail unless the change
suggested in G-1585 is applied. If you want I can disable this test.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12367045 ]
Jeff Genender commented on GERONIMO-1035:
-----------------------------------------
Thanks. The management patch works, but now your Tomcat cat patch will not compile. There seems to be some missing classes here as well also.
<depend closure="false" srcdir="1.4" dump="false" destdir="/Users/powerbook/Projects/geronimo/modules/tomcat/target/classes"></depend> [echo] Compiling to /Users/powerbook/Projects/geronimo/modules/tomcat/target/classes
[javac] Compiling 46 source files to /Users/powerbook/Projects/geronimo/modules/tomcat/target/classes
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ConnectorStats.java:31: cannot find symbol
[javac] symbol : class WebConnectorStatsImpl
[javac] location: package org.apache.geronimo.management.stats
[javac] import org.apache.geronimo.management.stats.WebConnectorStatsImpl;
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ConnectorStats.java:43: cannot find symbol
[javac] symbol : class WebConnectorStatsImpl
[javac] location: class org.apache.geronimo.tomcat.stats.ConnectorStats
[javac] private WebConnectorStatsImpl stats = new WebConnectorStatsImpl();
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ConnectorStats.java:64: cannot find symbol
[javac] symbol : class WebConnectorStatsImpl
[javac] location: class org.apache.geronimo.tomcat.stats.ConnectorStats
[javac] private void getStats(WebConnectorStatsImpl stats, String port){
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/TomcatServletHolder.java:40: cannot find symbol
[javac] symbol : class WebServletStatsImpl
[javac] location: package org.apache.geronimo.management.stats
[javac] import org.apache.geronimo.management.stats.WebServletStatsImpl;
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/TomcatServletHolder.java:66: cannot find symbol
[javac] symbol : class WebServletStatsImpl
[javac] location: class org.apache.geronimo.tomcat.TomcatServletHolder
[javac] private WebServletStatsImpl stats = new WebServletStatsImpl();
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/TomcatWebAppContext.java:49: cannot find symbol
[javac] symbol : class WebModuleStatsImpl
[javac] location: package org.apache.geronimo.management.stats
[javac] import org.apache.geronimo.management.stats.WebModuleStatsImpl;
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:33: cannot find symbol
[javac] symbol : class WebModuleStatsImpl
[javac] location: package org.apache.geronimo.management.stats
[javac] import org.apache.geronimo.management.stats.WebModuleStatsImpl;
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:45: cannot find symbol
[javac] symbol : class WebModuleStatsImpl
[javac] location: class org.apache.geronimo.tomcat.stats.ModuleStats
[javac] private WebModuleStatsImpl stats = new WebModuleStatsImpl();
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:81: cannot find symbol
[javac] symbol : class WebModuleStatsImpl
[javac] location: class org.apache.geronimo.tomcat.stats.ModuleStats
[javac] private void getStats(WebModuleStatsImpl stats, long processingTime, long startupTime,
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:81: getStats(java.lang.String,long,long,long) is already defined in org.apache.geronimo.tomcat.stats.ModuleStats
[javac] private void getStats(WebModuleStatsImpl stats, long processingTime, long startupTime,
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ConnectorStats.java:43: cannot find symbol
[javac] symbol : class WebConnectorStatsImpl
[javac] location: class org.apache.geronimo.tomcat.stats.ConnectorStats
[javac] private WebConnectorStatsImpl stats = new WebConnectorStatsImpl();
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/TomcatServletHolder.java:66: cannot find symbol
[javac] symbol : class WebServletStatsImpl
[javac] location: class org.apache.geronimo.tomcat.TomcatServletHolder
[javac] private WebServletStatsImpl stats = new WebServletStatsImpl();
[javac] ^
[javac] /Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:45: cannot find symbol
[javac] symbol : class WebModuleStatsImpl
[javac] location: class org.apache.geronimo.tomcat.stats.ModuleStats
[javac] private WebModuleStatsImpl stats = new WebModuleStatsImpl();
[javac] ^
[javac] Note: * uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] 13 errors
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap each servlet indiviudally
Posted by "anita kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12361190 ]
anita kulshreshtha commented on GERONIMO-1035:
----------------------------------------------
In the first phase, only add GBeans of j2EEType Servlet to provide ServletStats for Geronimo-1293. The web app would still be deployed by the tomcat deployer.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: anita kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Matt Hogstrom (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12450616 ]
Matt Hogstrom commented on GERONIMO-1035:
-----------------------------------------
Anita...can you review this JIRA and close if complete or move to the appropriate version ?
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assigned To: Jeff Genender
> Fix For: 1.2
>
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, pom.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Updated: (GERONIMO-1035) tomcat integration should wrap each servlet indiviudally
Posted by anita kulshreshtha <a_...@yahoo.com>.
There was a temporary outage at JIRA, hence so many attempts to
upload the patches. Please ignore the pom.xml patch.
Thanks
Anita
--- "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org> wrote:
> [ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
>
> Anita Kulshreshtha updated GERONIMO-1035:
> -----------------------------------------
>
> Attachment: management.patch
> pom.patch
>
> > tomcat integration should wrap each servlet indiviudally
> > --------------------------------------------------------
> >
> > Key: GERONIMO-1035
> > URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> > Project: Geronimo
> > Type: New Feature
> > Security: public(Regular issues)
> > Components: Tomcat
> > Versions: 1.0-M5
> > Environment: All
> > Reporter: Anita Kulshreshtha
> > Assignee: Jeff Genender
> > Fix For: 1.2
> > Attachments: application.patch, applications.patch,
> applications.patch, geronimo-stats-1.1-SNAPSHOT.war,
> management.patch, management.patch, management.patch,
> management.patch, management.patch, management.patch,
> management.patch, management.patch, pom.patch, stats.zip,
> tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch,
> tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch,
> tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch,
> tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch,
> tomcat.patch, tomcat.patch
> >
> > TomcatModuleBuilder should wrap each servlet specified in the
> deployment descriptor individually. This is needed by JSR-77 and for
> gathering tomcat internal statistics.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
> administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: management.patch
pom.patch
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Security: public(Regular issues)
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.2
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, pom.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12366997 ]
Anita Kulshreshtha commented on GERONIMO-1035:
----------------------------------------------
Right now neither container (AIUI) allows control of the lifecycle of the servlet. The reference to JSR-77 is in the context of ServletStats (JSR77.6.32). The TomcatServletHolder can be modified to add lifecycle controls when they are added to both containers. I agree that we will be able to add this functionality without actually adding the servlets via GBeans.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: management.patch
tomcat-builder.patch
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Security: public(Regular issues)
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.2
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: tomcat-builder.patch
management.patch
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Security: public(Regular issues)
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.2
> Attachments: application.patch, applications.patch, applications.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (GERONIMO-1035) tomcat integration should wrap each servlet indiviudally
Posted by anita kulshreshtha <a_...@yahoo.com>.
I attached few patches and Jira is showing 'split
personality'! Does any one know if the patches get
attached properly when this happens.
Thnaks
Anita
--- "Anita Kulshreshtha (JIRA)"
<de...@geronimo.apache.org> wrote:
> [
>
http://issues.apache.org/jira/browse/GERONIMO-1035?page=all
> ]
>
> Anita Kulshreshtha updated GERONIMO-1035:
> -----------------------------------------
>
> Attachment: tomcat.patch
> tomcat-builder.patch
> management.patch
>
> Patches upgraded to rev 380210. Both set of patches
> work fine.
>
> > tomcat integration should wrap each servlet
> indiviudally
> >
>
--------------------------------------------------------
> >
> > Key: GERONIMO-1035
> > URL:
> http://issues.apache.org/jira/browse/GERONIMO-1035
> > Project: Geronimo
> > Type: New Feature
> > Components: Tomcat
> > Versions: 1.0-M5
> > Environment: All
> > Reporter: Anita Kulshreshtha
> > Assignee: Jeff Genender
> > Fix For: 1.1
> > Attachments: application.patch,
> geronimo-stats-1.1-SNAPSHOT.war, management.patch,
> management.patch, management.patch,
> management.patch, stats.zip, tomcat-builder.patch,
> tomcat-builder.patch, tomcat-builder.patch,
> tomcat-builder.patch, tomcat-builder.patch,
> tomcat-builder.patch, tomcat-builder.patch,
> tomcat.patch, tomcat.patch, tomcat.patch,
> tomcat.patch
> >
> > TomcatModuleBuilder should wrap each servlet
> specified in the deployment descriptor individually.
> This is needed by JSR-77 and for gathering tomcat
> internal statistics.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of
> the administrators:
>
>
http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: tomcat.patch
tomcat-builder.patch
management.patch
Patches upgraded to rev 380210. Both set of patches work fine.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: application.patch, geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12366970 ]
Jeff Genender commented on GERONIMO-1035:
-----------------------------------------
One comment though...the JSR77 doesn't really apply here because you really are not controlling the lifecycle of the servlet with this code. You are controlling the GBean, which really is not controlling the lifecycle of the servlet itself, so you cannot start/stop the servlet. But there are ways to make this occur since you have access to the Context object.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1035) tomcat integration should wrap
each servlet indiviudally
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12366968 ]
Jeff Genender commented on GERONIMO-1035:
-----------------------------------------
Ok...I see what you did. Very nice work. I thought you were actually wrapping the servet, where you are really just tapping into the StandardWrapper. Give me a day or so to play with it and see if any issues crop up, and we can look into getting this into the code base.
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1035) tomcat integration should wrap each
servlet indiviudally
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=all ]
Anita Kulshreshtha updated GERONIMO-1035:
-----------------------------------------
Attachment: management.patch
Hmmm.. This is an older version. I am attaching the latest one. Thanks...
> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
> Key: GERONIMO-1035
> URL: http://issues.apache.org/jira/browse/GERONIMO-1035
> Project: Geronimo
> Type: New Feature
> Components: Tomcat
> Versions: 1.0-M5
> Environment: All
> Reporter: Anita Kulshreshtha
> Assignee: Jeff Genender
> Fix For: 1.1
> Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment descriptor individually. This is needed by JSR-77 and for gathering tomcat internal statistics.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira