You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "blackmwk (via GitHub)" <gi...@apache.org> on 2026/09/08 09:57:58 UTC
[I] [EPIC] Remove all pub field accessor. [iceberg-rust]
blackmwk opened a new issue, #3172:
URL: https://github.com/apache/iceberg-rust/issues/3172
### What's the feature are you trying to implement?
With more and more features introduced, we found one common requirement: we need to ensure that when a struct instance has been built, we need to ensure that it's valid. Some structs expose pub field accessors directly, which makes maintaining the guarantee infeasible. We need to remove all pub accessors of those struct.
### Willingness to contribute
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [EPIC] Remove all pub field accessor. [iceberg-rust]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on issue #3172:
URL: https://github.com/apache/iceberg-rust/issues/3172#issuecomment-5880059656
Adding usually easier than to remove. Before removing we need to make sure those pubs are not used by downstream/users. One thing is to use something like
```
#[deprecated(note = "the method modifier may change soon")]
```
Let it live for release or two, and change the modifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [EPIC] Remove all pub field accessor. [iceberg-rust]
Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk commented on issue #3172:
URL: https://github.com/apache/iceberg-rust/issues/3172#issuecomment-5889276767
> Adding usually easier than to remove. Before removing we need to make sure those pubs are not used by downstream/users. One thing is to use something like
>
> ```
> #[deprecated(note = "the method modifier may change soon")]
> ```
>
> Let it live for release or two, and change the modifier
Hi, @comphead This is a good suggestion in most case for migrating apis, but not suitable in this case, since pub accessor is going to break the guarantee that a constructed structs is always valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org