[GitHub] [airflow] uranusjr commented on a diff in pull request #23317: Add DagWarning model, and a check for missing pools

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #23317:
URL: https://github.com/apache/airflow/pull/23317#discussion_r897621531


##########
airflow/migrations/versions/0111_2_4_0_add_dagwarning_model.py:
##########
@@ -0,0 +1,74 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Add DagWarning model
+
+Revision ID: 424117c37d18
+Revises: 3c94c427fdf6
+Create Date: 2022-04-27 15:57:36.736743
+"""
+
+import sqlalchemy as sa
+from alembic import op
+
+# revision identifiers, used by Alembic.
+from sqlalchemy import Column, Integer
+
+from airflow.migrations.db_types import StringID
+
+revision = '424117c37d18'
+down_revision = '3c94c427fdf6'
+branch_labels = None
+depends_on = None
+airflow_version = '2.4.0'
+
+
+def upgrade():
+    """Apply Add DagWarning model"""
+    op.create_table(
+        'dag_warning',
+        Column(
+            'id',
+            Integer,
+            nullable=False,
+            autoincrement=True,
+            primary_key=True,
+        ),
+        sa.Column('dag_id', StringID(), nullable=False),
+        sa.Column('warning_type', sa.String(length=50), nullable=False),
+        sa.Column('message', sa.String(1000), nullable=False),
+        sa.Column('timestamp', sa.DateTime(), nullable=False),

Review Comment:
   “Traditionally” Airflow uses a timezone-less column to store UTC time, and do the conversion in with `UtcDateTime`. But I _think_ there’s a loose recognision to use `TIMESTAMP` in new code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org