You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/07/31 18:38:53 UTC
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #806: DISPATCH-1736 - Removed skip_test flag that was wrongly added in comm…
ganeshmurthy opened a new pull request #806:
URL: https://github.com/apache/qpid-dispatch/pull/806
…it 4a173e1ec0f7e0e8f9d7d37b9549d4f9c9d37fb0. This test should run all arches, 32 or 64 bit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #806: DISPATCH-1736 - Removed skip_test flag that was wrongly added in comm…
Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #806:
URL: https://github.com/apache/qpid-dispatch/pull/806#discussion_r463826667
##########
File path: tests/system_tests_protocol_settings.py
##########
@@ -245,7 +234,6 @@ def test_max_session_frames_default(self):
# if frame size not set then a default is used
self.assertTrue(" max-frame-size=16384" in open_lines[0])
begin_lines = [s for s in log_lines if "-> @begin" in s]
- # incoming-window is from the config
Review comment:
I'd instead explain where is the number coming from. Maybe
```# incoming-window is the Proton default```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #806: DISPATCH-1736 - Removed skip_test flag that was wrongly added in comm…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #806:
URL: https://github.com/apache/qpid-dispatch/pull/806
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org