[jira] [Commented] (HBASE-6941) LoadIncrementalHFiles uses the Tool interface incorrectly for loading configs

["Harsh J (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-6941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468932#comment-13468932 ] 

Harsh J commented on HBASE-6941:
--------------------------------

- Unified the configuration to use the getConf() from Configured alone. Added HBase configs to it upon construction. This is the "right" way to use Tool + HBaseConfiguration.
- Constantized 3 of the used config params in the tool, to HConstants, and updated their references in the tool.
                
> LoadIncrementalHFiles uses the Tool interface incorrectly for loading configs
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6941
>                 URL: https://issues.apache.org/jira/browse/HBASE-6941
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.90.6
>            Reporter: Harsh J
>            Assignee: Harsh J
>         Attachments: HBASE-6941.patch
>
>
> The LoadIncrementalHFiles tool has pretty complex config loading structured in it, which seems unnecessary and also causes problem since it is ignoring any settings passed to it via Tool's -Dprop=value parameters.
> This makes integration with tools such as Oozie harder, as it doesn't accept different addresses of ZK, etc. unless there's a hbase-site.xml on the classpath to load from (which is painful to achieve on Oozie).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira