[GitHub] [incubator-superset] eschutho commented on a change in pull request #11181: fix: keep placeholder in multivalue select when a value exists

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #11181:
URL: https://github.com/apache/incubator-superset/pull/11181#discussion_r501367755



##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -272,6 +294,24 @@ export const DEFAULT_COMPONENTS: SelectComponentsConfig<any> = {
       />
     </DropdownIndicator>
   ),
+  Input: (props: InputProps) => (
+    <div style={{ position: 'relative' }}>
+      <Input {...props} />
+      {!!(props.selectProps.isMulti && props.selectProps.value.length) && (
+        <span
+          style={{
+            color: '#879399',
+            position: 'absolute',
+            top: '2px',
+            left: '4px',
+            width: '100vw',

Review comment:
       ok, I put the styles in a const.. seems to be a common pattern? 
   I didn't see a way to pull a color in from a pallet, though, so it's hard-coded unless there's any advice there. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org