You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/15 03:48:46 UTC

[GitHub] john-bodley commented on a change in pull request #4827: [config] Updating configuration logic

john-bodley commented on a change in pull request #4827: [config] Updating configuration logic
URL: https://github.com/apache/incubator-superset/pull/4827#discussion_r181569352
 
 

 ##########
 File path: tests/superset.conf
 ##########
 @@ -1,18 +1,12 @@
 # -*- coding: utf-8 -*-
 # flake8: noqa
-from superset.config import *
+import os
 
 AUTH_USER_REGISTRATION_ROLE = 'alpha'
-SQLALCHEMY_DATABASE_URI = 'sqlite:///' + os.path.join(DATA_DIR, 'unittests.db')
 DEBUG = True
 SUPERSET_WEBSERVER_PORT = 8081
-
 
 Review comment:
   This logic is now simplified given that all unit tests are run via the `tox` testing harness.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services