You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by krishnakalyan3 <gi...@git.apache.org> on 2016/12/10 00:46:53 UTC
[GitHub] spark pull request #16242: [SPARK-18628][ML] Update Scala param and Python p...
GitHub user krishnakalyan3 opened a pull request:
https://github.com/apache/spark/pull/16242
[SPARK-18628][ML] Update Scala param and Python param to have quotes
## What changes were proposed in this pull request?
Updated Scala param and Python param to have quotes around the options making it easier for users to read.
## How was this patch tested?
Manually checked the docstrings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/krishnakalyan3/spark doc-string
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16242
----
commit f5ffee7e970297347c25d972d820743d7a72b9f3
Author: krishnakalyan3 <kr...@gmail.com>
Date: 2016-12-10T00:30:45Z
add quotes around options
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16242: [SPARK-18628][ML] Update Scala param and Python param to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16242
**[Test build #3487 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3487/consoleFull)** for PR 16242 at commit [`f5ffee7`](https://github.com/apache/spark/commit/f5ffee7e970297347c25d972d820743d7a72b9f3).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16242: [SPARK-18628][ML] Update Scala param and Python param to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16242
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16242: [SPARK-18628][ML] Update Scala param and Python param to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16242
**[Test build #3491 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3491/consoleFull)** for PR 16242 at commit [`c296f1e`](https://github.com/apache/spark/commit/c296f1e5aca8fb6abf082b9d39163c10fe819cbe).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16242: [SPARK-18628][ML] Update Scala param and Python param to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16242
**[Test build #3487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3487/consoleFull)** for PR 16242 at commit [`f5ffee7`](https://github.com/apache/spark/commit/f5ffee7e970297347c25d972d820743d7a72b9f3).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16242: [SPARK-18628][ML] Update Scala param and Python param to...
Posted by krishnakalyan3 <gi...@git.apache.org>.
Github user krishnakalyan3 commented on the issue:
https://github.com/apache/spark/pull/16242
cc @MLnick and @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16242: [SPARK-18628][ML] Update Scala param and Python p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16242: [SPARK-18628][ML] Update Scala param and Python param to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16242
**[Test build #3491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3491/consoleFull)** for PR 16242 at commit [`c296f1e`](https://github.com/apache/spark/commit/c296f1e5aca8fb6abf082b9d39163c10fe819cbe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org