You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (Created) (JIRA)" <ji...@apache.org> on 2011/11/25 00:30:40 UTC
[jira] [Created] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
---------------------------------------------------------------------------------------------------------------------------------
Key: LUCENE-3595
URL: https://issues.apache.org/jira/browse/LUCENE-3595
Project: Lucene - Java
Issue Type: Task
Reporter: Uwe Schindler
Assignee: Uwe Schindler
Followup from LUCENE-3593:
The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157148#comment-13157148 ]
Uwe Schindler commented on LUCENE-3595:
---------------------------------------
I committed a change in trunk branch to do the acceptDocs check after the matchDoc() to be consistent with other implementations. This should also be faster as bit twiddling is only done when a match was found.
At revision: 1206155
> Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3595
> URL: https://issues.apache.org/jira/browse/LUCENE-3595
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3595-3x.patch, LUCENE-3595-3x.patch, LUCENE-3595-trunk.patch, LUCENE-3595-trunk.patch
>
>
> Followup from LUCENE-3593:
> The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
> Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
> This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3595:
----------------------------------
Attachment: LUCENE-3595-3x.patch
Improvements. Ready to commit.
> Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3595
> URL: https://issues.apache.org/jira/browse/LUCENE-3595
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-3595-3x.patch, LUCENE-3595-3x.patch, LUCENE-3595-trunk.patch, LUCENE-3595-trunk.patch
>
>
> Followup from LUCENE-3593:
> The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
> Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
> This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3595:
----------------------------------
Attachment: LUCENE-3595-trunk.patch
Final patch for trunk, will commit now and backport.
> Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3595
> URL: https://issues.apache.org/jira/browse/LUCENE-3595
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-3595-trunk.patch, LUCENE-3595-trunk.patch
>
>
> Followup from LUCENE-3593:
> The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
> Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
> This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3595:
----------------------------------
Attachment: (was: LUCENE-3595-trunk.patch)
> Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3595
> URL: https://issues.apache.org/jira/browse/LUCENE-3595
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-3595-trunk.patch
>
>
> Followup from LUCENE-3593:
> The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
> Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
> This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156953#comment-13156953 ]
Uwe Schindler commented on LUCENE-3595:
---------------------------------------
Committed trunk revision: 1206033
Now backporting.
> Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3595
> URL: https://issues.apache.org/jira/browse/LUCENE-3595
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-3595-trunk.patch, LUCENE-3595-trunk.patch
>
>
> Followup from LUCENE-3593:
> The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
> Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
> This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3595:
----------------------------------
Attachment: LUCENE-3595-3x.patch
Patch for Lucene 3.x. This also fixes the TODO in LUCENE-3593 (respects deleted docs for the FixedBitSet case).
> Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3595
> URL: https://issues.apache.org/jira/browse/LUCENE-3595
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-3595-3x.patch, LUCENE-3595-trunk.patch, LUCENE-3595-trunk.patch
>
>
> Followup from LUCENE-3593:
> The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
> Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
> This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3595:
----------------------------------
Attachment: LUCENE-3595-trunk.patch
Previous patch had missing "else".
> Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3595
> URL: https://issues.apache.org/jira/browse/LUCENE-3595
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-3595-trunk.patch
>
>
> Followup from LUCENE-3593:
> The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
> Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
> This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3595:
----------------------------------
Attachment: LUCENE-3595-trunk.patch
Patch for trunk.
> Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3595
> URL: https://issues.apache.org/jira/browse/LUCENE-3595
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-3595-trunk.patch
>
>
> Followup from LUCENE-3593:
> The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
> Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
> This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3595) Refactor
FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the
dangerous matchDoc() throws AIOOBE requirement
Posted by "Uwe Schindler (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-3595.
-----------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.6
Committed 3.x revision: 1206040
> Refactor FieldCacheRangeFilter.FieldCacheDocIdSet to be separate class and fix the dangerous matchDoc() throws AIOOBE requirement
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3595
> URL: https://issues.apache.org/jira/browse/LUCENE-3595
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3595-3x.patch, LUCENE-3595-3x.patch, LUCENE-3595-trunk.patch, LUCENE-3595-trunk.patch
>
>
> Followup from LUCENE-3593:
> The FieldCacheRangeFilter.FieldCacheDocIdSet class has a strange requirement on the abstract matchDoc(): It should throw AIOOBE if the docId is > maxDoc. This check should be done by caller as especially on trunk, e.g. FieldCacheTermsFilter does not seem to always throw this exception correctly (getOrd() is a method and no array in TermsIndex cache).
> Also in 3.x the Filter does not correctly respect deletions when a FieldCache based on a reopened reader is used.
> This issue will refactor this and fix the bugs and moves the docId check up to the iterator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org