You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/02/01 13:52:50 UTC

[GitHub] [echarts] pissang commented on pull request #14177: Feat: dev-fase use esbuild watch mode

pissang commented on pull request #14177:
URL: https://github.com/apache/echarts/pull/14177#issuecomment-770872255


   That's great!
   
   BTW: I investigated the doc of esbuild again and found [banner](https://esbuild.github.io/api/#banner) and [footer](https://esbuild.github.io/api/#footer) can be used to wrap the UMD code. Do you mind having a try on it in this PR so we can avoid handling source-map by ourselves


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org