You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/08/06 02:43:10 UTC
Review Request 37152: Hosts Page Performance: Avoid triggering hosts
loading immediately after switching to hosts tab
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37152/
-----------------------------------------------------------
Review request for Ambari, Andrii Tkach, Jaimin Jetly, and Yusaku Sako.
Bugs: AMBARI-12656
https://issues.apache.org/jira/browse/AMBARI-12656
Repository: ambari
Description
-------
When the page of hosts has already been loaded to FE model store, we should avoid trigger hosts loading when user switch in/out hosts tab. Just reuse the front-end model to render the page and schedule an update request after a few seconds.
Diffs
-----
ambari-web/app/controllers/main/host.js 9d8347c
ambari-web/app/routes/main.js af86eda
ambari-web/app/views/main/host.js 6ab3d22
ambari-web/app/views/main/menu.js 40f9781
Diff: https://reviews.apache.org/r/37152/diff/
Testing
-------
Manually tested on live cluster.
Unit tests passed.
6486 tests complete (9 seconds)
94 tests pending
Thanks,
Richard Zang
Re: Review Request 37152: Hosts Page Performance: Avoid triggering
hosts loading immediately after switching to hosts tab
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37152/#review95038
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Aug. 6, 2015, 12:43 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37152/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 12:43 a.m.)
>
>
> Review request for Ambari, Andrii Tkach, Jaimin Jetly, and Yusaku Sako.
>
>
> Bugs: AMBARI-12656
> https://issues.apache.org/jira/browse/AMBARI-12656
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When the page of hosts has already been loaded to FE model store, we should avoid trigger hosts loading when user switch in/out hosts tab. Just reuse the front-end model to render the page and schedule an update request after a few seconds.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host.js 9d8347c
> ambari-web/app/routes/main.js af86eda
> ambari-web/app/views/main/host.js 6ab3d22
> ambari-web/app/views/main/menu.js 40f9781
>
> Diff: https://reviews.apache.org/r/37152/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
> Unit tests passed.
>
> 6486 tests complete (9 seconds)
> 94 tests pending
>
>
> Thanks,
>
> Richard Zang
>
>