You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/01/09 15:16:02 UTC

Review Request 29764: Change status calculation for Upgrade Groups / Items

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29764/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-8811
    https://issues.apache.org/jira/browse/AMBARI-8811


Repository: ambari


Description
-------

The existing calculation to determine the status for Upgrade Groups / Items returns PENDING if some of the sub-tasks are PENDING, even if other sub-tasks have COMPLETED.

Change the calculation so that the returned status will only be PENDING if all of the sub-tasks are PENDING.  In the case where some sub-tasks are PENDING while others have COMPLETED, the returned status will be IN_PROGRESS.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 9529001 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java cdb5eb7 

Diff: https://reviews.apache.org/r/29764/diff/


Testing
-------

New unit test cases added.  All tests pass ...

Results :

Tests run: 2495, Failures: 0, Errors: 0, Skipped: 13


[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:44 min
[INFO] Finished at: 2015-01-09T09:04:19-05:00


Thanks,

Tom Beerbower


Re: Review Request 29764: Change status calculation for Upgrade Groups / Items

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29764/#review67449
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Jan. 9, 2015, 9:16 a.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29764/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 9:16 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-8811
>     https://issues.apache.org/jira/browse/AMBARI-8811
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The existing calculation to determine the status for Upgrade Groups / Items returns PENDING if some of the sub-tasks are PENDING, even if other sub-tasks have COMPLETED.
> 
> Change the calculation so that the returned status will only be PENDING if all of the sub-tasks are PENDING.  In the case where some sub-tasks are PENDING while others have COMPLETED, the returned status will be IN_PROGRESS.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 9529001 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java cdb5eb7 
> 
> Diff: https://reviews.apache.org/r/29764/diff/
> 
> 
> Testing
> -------
> 
> New unit test cases added.  All tests pass ...
> 
> Results :
> 
> Tests run: 2495, Failures: 0, Errors: 0, Skipped: 13
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:44 min
> [INFO] Finished at: 2015-01-09T09:04:19-05:00
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>