You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/10 02:52:19 UTC

[GitHub] [druid] FrankChen021 opened a new pull request, #13068: export `com.sun.management.internal` when running Druid under JRE11 and JRE17

FrankChen021 opened a new pull request, #13068:
URL: https://github.com/apache/druid/pull/13068

   Fixes #12312 which was reported half a year ago. 
   
   
   This PR has:
   - [X] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [X] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm merged pull request #13068: export `com.sun.management.internal` when running Druid under JRE11 and JRE17

Posted by GitBox <gi...@apache.org>.
gianm merged PR #13068:
URL: https://github.com/apache/druid/pull/13068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm commented on pull request #13068: export `com.sun.management.internal` when running Druid under JRE11 and JRE17

Posted by GitBox <gi...@apache.org>.
gianm commented on PR #13068:
URL: https://github.com/apache/druid/pull/13068#issuecomment-1243001354

   Couple questions:
   
   - Is this still needed after the changes to JvmMonitor in #12481?
   - Is it `--add-exports` or `--add-opens` that we need?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] FrankChen021 commented on pull request #13068: export `com.sun.management.internal` when running Druid under JRE11 and JRE17

Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on PR #13068:
URL: https://github.com/apache/druid/pull/13068#issuecomment-1243138459

   > * Is this still needed after the changes to JvmMonitor in [Use MXBeans to get GC metrics #12476 #12481](https://github.com/apache/druid/pull/12481)?
   
   Yes, we need it. The `AllocationMetricCollector` differs from the JvmMonitor that we changed before, and I have not found a management API to replace it.
   
   > * Is it `--add-exports` or `--add-opens` that we need?
   
   Basically, `add-opens` can be seen as a super set of `add-exports`. The former one allows us to access non-public methods via reflection while the latter one allows us to access public methods only. Use `add-opens` makes the things simpler.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org