You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Stephen Friedrich (JIRA)" <de...@myfaces.apache.org> on 2007/10/18 20:49:50 UTC
[jira] Created: (TRINIDAD-775) panelButtonBar is missing skinning
panelButtonBar is missing skinning
----------------------------------
Key: TRINIDAD-775
URL: https://issues.apache.org/jira/browse/TRINIDAD-775
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 1.0.3-core
Reporter: Stephen Friedrich
My client's styleguide mandates 15px gap between buttons.
When I did not find anything in the skin selectors doc at first I thought the doc was just missing.
When I inspected my page with Firebug I saw that a spacer image was hardcoded with 10px width and thought that the renderer was probably using a skinning property.
So I looked at the source and found this in PanelButtonBarRenderer:
protected void encodeSeparator( ...
{
// FIXME Use proper skinning techniques
renderSpacer(context, rc, "10", "1");
....
Well, yeah, a fix would be nice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-775) panelButtonBar is missing skinning
Posted by "Stephen Friedrich (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536045 ]
Stephen Friedrich commented on TRINIDAD-775:
--------------------------------------------
This is an - ugly - workaround:
af|panelButtonBar tbody tr td img {
width: 15px !important;
}
> panelButtonBar is missing skinning
> ----------------------------------
>
> Key: TRINIDAD-775
> URL: https://issues.apache.org/jira/browse/TRINIDAD-775
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.3-core
> Reporter: Stephen Friedrich
>
> My client's styleguide mandates 15px gap between buttons.
> When I did not find anything in the skin selectors doc at first I thought the doc was just missing.
> When I inspected my page with Firebug I saw that a spacer image was hardcoded with 10px width and thought that the renderer was probably using a skinning property.
> So I looked at the source and found this in PanelButtonBarRenderer:
> protected void encodeSeparator( ...
> {
> // FIXME Use proper skinning techniques
> renderSpacer(context, rc, "10", "1");
> ....
> Well, yeah, a fix would be nice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-775) panelButtonBar is missing skinning
Posted by "Carsten Pieper (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610223#action_12610223 ]
Carsten Pieper commented on TRINIDAD-775:
-----------------------------------------
Yes, indeed, the given workaround is ugly. I came up with the same dirty workaround
(OK , 5px in my case ;-) ), but this had unwanted side effects:
Assume you have a panelButtonBar which doesn't only contain buttons but also
commandLinks with icons in it. The rendered icon's img would be effected by
this setting, too, getting a width of 15px (well, 5px with me)...
The situation described above might not really be what the panelButtonBar's creators
had in mind but it might be something (a clickable icon doesn't "feel" so far off from
a normal button, does it?) that others might run into, too...
> panelButtonBar is missing skinning
> ----------------------------------
>
> Key: TRINIDAD-775
> URL: https://issues.apache.org/jira/browse/TRINIDAD-775
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.0.3-core
> Reporter: Stephen Friedrich
>
> My client's styleguide mandates 15px gap between buttons.
> When I did not find anything in the skin selectors doc at first I thought the doc was just missing.
> When I inspected my page with Firebug I saw that a spacer image was hardcoded with 10px width and thought that the renderer was probably using a skinning property.
> So I looked at the source and found this in PanelButtonBarRenderer:
> protected void encodeSeparator( ...
> {
> // FIXME Use proper skinning techniques
> renderSpacer(context, rc, "10", "1");
> ....
> Well, yeah, a fix would be nice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.