You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2013/07/02 02:23:39 UTC
Review Request 12216: SQOOP-1089 Sqoop2: Accept Language header default
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12216/
-----------------------------------------------------------
Review request for Sqoop, Hari Shreedharan and Jarek Cecho.
Bugs: SQOOP-1089
https://issues.apache.org/jira/browse/SQOOP-1089
Repository: sqoop-sqoop2
Description
-------
commit 1db0513e9ddd4c1f7d3b389f0d4932b2bd96e3ee
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Mon Jul 1 17:18:29 2013 -0700
SQOOP-1089 Sqoop2: Accept Language header default
Using Locale.getDefault().
:100644 100644 4ed7f58... f65017a... M server/src/main/java/org/apache/sqoop/server/RequestContext.java
Diffs
-----
server/src/main/java/org/apache/sqoop/server/RequestContext.java 4ed7f58
Diff: https://reviews.apache.org/r/12216/diff/
Testing
-------
mvn test
curl http://solaris:12000/sqoop/v1/connector/all no longer throws and exception.
Thanks,
Abraham Elmahrek
Re: Review Request 12216: SQOOP-1089 Sqoop2: Accept Language header default
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12216/#review22640
-----------------------------------------------------------
Ship it!
(letting Hari to do the commit)
- Jarek Cecho
On July 2, 2013, 12:29 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12216/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 12:29 a.m.)
>
>
> Review request for Sqoop, Hari Shreedharan and Jarek Cecho.
>
>
> Bugs: SQOOP-1089
> https://issues.apache.org/jira/browse/SQOOP-1089
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 1db0513e9ddd4c1f7d3b389f0d4932b2bd96e3ee
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Mon Jul 1 17:18:29 2013 -0700
>
> SQOOP-1089 Sqoop2: Accept Language header default
>
> Using Locale.getDefault().
>
> :100644 100644 4ed7f58... f65017a... M server/src/main/java/org/apache/sqoop/server/RequestContext.java
>
>
> Diffs
> -----
>
> server/src/main/java/org/apache/sqoop/server/RequestContext.java 4ed7f58b3ac56f3ea0f37d1b1b9ad681d1716f32
>
> Diff: https://reviews.apache.org/r/12216/diff/
>
>
> Testing
> -------
>
> mvn test
> curl http://solaris:12000/sqoop/v1/connector/all no longer throws and exception.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 12216: SQOOP-1089 Sqoop2: Accept Language header default
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12216/
-----------------------------------------------------------
(Updated July 2, 2013, 12:29 a.m.)
Review request for Sqoop, Hari Shreedharan and Jarek Cecho.
Changes
-------
Fix formatting.
Bugs: SQOOP-1089
https://issues.apache.org/jira/browse/SQOOP-1089
Repository: sqoop-sqoop2
Description
-------
commit 1db0513e9ddd4c1f7d3b389f0d4932b2bd96e3ee
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Mon Jul 1 17:18:29 2013 -0700
SQOOP-1089 Sqoop2: Accept Language header default
Using Locale.getDefault().
:100644 100644 4ed7f58... f65017a... M server/src/main/java/org/apache/sqoop/server/RequestContext.java
Diffs (updated)
-----
server/src/main/java/org/apache/sqoop/server/RequestContext.java 4ed7f58b3ac56f3ea0f37d1b1b9ad681d1716f32
Diff: https://reviews.apache.org/r/12216/diff/
Testing
-------
mvn test
curl http://solaris:12000/sqoop/v1/connector/all no longer throws and exception.
Thanks,
Abraham Elmahrek
Re: Review Request 12216: SQOOP-1089 Sqoop2: Accept Language header default
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12216/#review22637
-----------------------------------------------------------
Ship it!
+1. This looks good. I will run tests and commit later today unless there is any objection.
- Hari Shreedharan
On July 2, 2013, 12:23 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12216/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 12:23 a.m.)
>
>
> Review request for Sqoop, Hari Shreedharan and Jarek Cecho.
>
>
> Bugs: SQOOP-1089
> https://issues.apache.org/jira/browse/SQOOP-1089
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 1db0513e9ddd4c1f7d3b389f0d4932b2bd96e3ee
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Mon Jul 1 17:18:29 2013 -0700
>
> SQOOP-1089 Sqoop2: Accept Language header default
>
> Using Locale.getDefault().
>
> :100644 100644 4ed7f58... f65017a... M server/src/main/java/org/apache/sqoop/server/RequestContext.java
>
>
> Diffs
> -----
>
> server/src/main/java/org/apache/sqoop/server/RequestContext.java 4ed7f58
>
> Diff: https://reviews.apache.org/r/12216/diff/
>
>
> Testing
> -------
>
> mvn test
> curl http://solaris:12000/sqoop/v1/connector/all no longer throws and exception.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>