[jira] [Issue Comment Edited] (OGNL-27) Move "toString" implementations into visitor pattern.

["Daniel Pitts (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OGNL-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128270#comment-13128270 ] 

Daniel Pitts edited comment on OGNL-27 at 10/15/11 9:50 PM:
------------------------------------------------------------

Okay, I'll make those changes next time I have a free block of time.
                
      was (Author: danielpitts):
    Okay, I'll make those changes next time I have a free block of time.

Thanks,
Daniel.

Sent from my iPhone

On Oct 15, 2011, at 12:39 PM, "Simone Tripodi (Commented) (JIRA)"


                  
> Move "toString" implementations into visitor pattern.
> -----------------------------------------------------
>
>                 Key: OGNL-27
>                 URL: https://issues.apache.org/jira/browse/OGNL-27
>             Project: OGNL
>          Issue Type: New Feature
>            Reporter: Daniel Pitts
>         Attachments: to_string_visitor1.patch
>
>
> Using the Visitor pattern allows for a cleaner implementation of toString().
> I have a patch which will remove toString() from all AST classes, and replace it with a single toString() in "SimpleNode" which delegates to a ToStringVisitor to build the String efficiently.  
> This patch can also be used as an example of how to move other business logic out of the AST classes into their own visitor classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira