You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/01/10 01:35:31 UTC
[GitHub] [incubator-livy] codecov-io edited a comment on issue #274:
[LIVY-718] Distributed session id generation
codecov-io edited a comment on issue #274: [LIVY-718] Distributed session id generation
URL: https://github.com/apache/incubator-livy/pull/274#issuecomment-572834042
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/274?src=pr&el=h1) Report
> Merging [#274](https://codecov.io/gh/apache/incubator-livy/pull/274?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/66b5833e413bc10e39e3b92b585f496444c147d4?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `60.78%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/274?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #274 +/- ##
============================================
- Coverage 68.14% 68.09% -0.06%
- Complexity 959 968 +9
============================================
Files 104 107 +3
Lines 5946 5986 +40
Branches 899 902 +3
============================================
+ Hits 4052 4076 +24
- Misses 1312 1327 +15
- Partials 582 583 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/274?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/livy/server/recovery/SessionStore.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvcmVjb3ZlcnkvU2Vzc2lvblN0b3JlLnNjYWxh) | `76.19% <0%> (-3.81%)` | `10 <0> (ø)` | |
| [.../livy/sessions/DistributedSessionIdGenerator.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXNzaW9ucy9EaXN0cmlidXRlZFNlc3Npb25JZEdlbmVyYXRvci5zY2FsYQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../org/apache/livy/sessions/SessionIdGenerator.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXNzaW9ucy9TZXNzaW9uSWRHZW5lcmF0b3Iuc2NhbGE=) | `100% <100%> (ø)` | `1 <1> (?)` | |
| [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.19% <100%> (+0.05%)` | `21 <0> (ø)` | :arrow_down: |
| [...apache/livy/sessions/LocalSessionIdGenerator.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXNzaW9ucy9Mb2NhbFNlc3Npb25JZEdlbmVyYXRvci5zY2FsYQ==) | `100% <100%> (ø)` | `4 <4> (?)` | |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `32.88% <50%> (-0.6%)` | `11 <0> (ø)` | |
| [...apache/livy/server/recovery/ZooKeeperManager.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvcmVjb3ZlcnkvWm9vS2VlcGVyTWFuYWdlci5zY2FsYQ==) | `66% <55.55%> (-0.67%)` | `19 <2> (+2)` | |
| [...cala/org/apache/livy/sessions/SessionManager.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXNzaW9ucy9TZXNzaW9uTWFuYWdlci5zY2FsYQ==) | `81.48% <81.25%> (-0.34%)` | `27 <3> (ø)` | |
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `52.94% <0%> (-2.95%)` | `7% <0%> (ø)` | |
| [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `30.76% <0%> (-2.57%)` | `7% <0%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-livy/pull/274/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/274?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/274?src=pr&el=footer). Last update [66b5833...f6f9776](https://codecov.io/gh/apache/incubator-livy/pull/274?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services