You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/03/04 15:38:18 UTC
[Bug 59116] New: Add the possibility to setup a prefix to sampler
name recorded by proxy
https://bz.apache.org/bugzilla/show_bug.cgi?id=59116
Bug ID: 59116
Summary: Add the possibility to setup a prefix to sampler name
recorded by proxy
Product: JMeter
Version: Nightly (Please specify date)
Hardware: PC
OS: Windows NT
Status: NEW
Severity: enhancement
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: ra0077@gmail.com
Hi,
I have add a new option in proxy recorder to add a prefix in sampler name
recorded by the proxy.
It allow to be more productive (less work to rename samplers after a recording)
and complete the regex in backend listener I have add previously
Antonio
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59116] Add the possibility to setup a prefix to sampler name
recorded by proxy
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59116
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Thanks for PR.
I made few modification , see comments.
Author: pmouawad
Date: Fri Mar 4 22:16:39 2016
New Revision: 1733665
URL: http://svn.apache.org/viewvc?rev=1733665&view=rev
Log:
Bug 59116 - Add the possibility to setup a prefix to sampler name recorded by
proxy
#resolve #158
Fixed the following in PR:
- SampleResult did not match the modified Sample label
- Added code in keyListener to ensure the model is updated, otherwise the
ProxyControl would still use old prefix until user leaves the component
- French label
Bugzilla Id: 59116
Modified:
jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59116] Add the possibility to setup a prefix to sampler name
recorded by proxy
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59116
--- Comment #3 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
PR 158 without tab commited
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59116] Add the possibility to setup a prefix to sampler name
recorded by proxy
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59116
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
Hardware|PC |All
Version|Nightly (Please specify |2.13
|date) |
OS|Windows NT |All
CC| |p.mouawad@ubik-ingenierie.c
| |om
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59116] Add the possibility to setup a prefix to sampler name
recorded by proxy
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59116
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Sebb <se...@apache.org> ---
(In reply to Antonio Gomes Rodrigues from comment #1)
> PR 156 commited
> https://github.com/apache/jmeter/pull/156.patch
Sorry, but the patch is unusable as it stands.
There are huge numbers of irrelevant changes which make it all but impossible
to review. Here is the summary:
.../apache/jmeter/resources/messages.properties | 2689 ++++++++---------
.../apache/jmeter/resources/messages_fr.properties | 2659 ++++++++---------
.../jmeter/protocol/http/proxy/ProxyControl.java | 3039 ++++++++++----------
.../protocol/http/proxy/gui/ProxyControlGui.java | 25 +-
4 files changed, 4223 insertions(+), 4189 deletions(-)
I would expect a patch to fix this to be 100 changes or so, not 1000s.
Patches should contain the minimum number of changes.
This allows developers to quickly review the proposed change.
Also once the patch is applied, it makes the history easier to read.
If you want the patch to be applied, please provide a minimal one.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59116] Add the possibility to setup a prefix to sampler name
recorded by proxy
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59116
Antonio Gomes Rodrigues <ra...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59116] Add the possibility to setup a prefix to sampler name
recorded by proxy
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59116
--- Comment #5 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
Thanks to the modifications
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59116] Add the possibility to setup a prefix to sampler name
recorded by proxy
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59116
--- Comment #1 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
PR 156 commited
--
You are receiving this mail because:
You are the assignee for the bug.