You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/20 09:06:29 UTC
[GitHub] [apisix] LY-GO opened a new issue #2477: request help: add plugins of key
LY-GO opened a new issue #2477:
URL: https://github.com/apache/apisix/issues/2477
### Issue description
i want to add key for limit-plugin;it can accomplish limit according to service_id;If i want to implement the function,you can give some suggestion.Thanks!
### Environment
* apisix version (cmd: `apisix version`):
* OS:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO removed a comment on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO removed a comment on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715192130
> > 2. now i set key in the following way,but service_id is nil.Why is that?
>
> do you bind any service to route?
yes
![Uploading services.png…]()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add plugins of key
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-713230856
> 1. you need to use a better title.
> 2. one issue for one thing: add `service_id` as key to plugin `limit-*`, do you mean this?
Sorry,my English not better;one issue : add `service_id` as key to plugin `limit-*`,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715420065
> this old version dashboard, so it not support `service_id` as key.
new version supports service_id as key?my version is 1.5,Is there any other version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-717255592
https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count.lua#L39
plugin `limit-count`, it has supported using `service_id` as key in master branch.
which plugin you want to support `service_id` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-955184326
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715352290
this old version dashboard, so it not support `service_id` as key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add plugins of key
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-713231251
Sorry,my English not better;one issue : add service_id as key to plugin limit-*,i mean that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO removed a comment on issue #2477: request help: add plugins of key
Posted by GitBox <gi...@apache.org>.
LY-GO removed a comment on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-713230856
> 1. you need to use a better title.
> 2. one issue for one thing: add `service_id` as key to plugin `limit-*`, do you mean this?
Sorry,my English not better;one issue : add `service_id` as key to plugin `limit-*`,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #2477:
URL: https://github.com/apache/apisix/issues/2477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-717259025
> please make a try with the master branch ^_^
I can require service_id from Eureka?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715653856
> > this old version dashboard, so it not support `service_id` as key.
>
> new version supports service_id as key?my version is 1.5,Is there any other version
The new dashboard doesn't support the Service module currently.
tracking issue: https://github.com/apache/apisix-dashboard/issues/471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-717266709
> https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count.lua#L39
>
> plugin `limit-count`, it has supported using `service_id` as key in master branch.
>
> which plugin you want to support `service_id` ?
plugin of limit-conn and limit-req
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715251639
> > 2. now i set key in the following way,but service_id is nil.Why is that?
>
> do you bind any service to route?
we can use core.var.service_id to acquire value of service_id?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715646989
please make a try with the master branch ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO edited a comment on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO edited a comment on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-718314185
> welcome to submit PR to support `service_id` for `limit-conn` or `limit-req`.
>
> they were should be the same as `limit-count`.
How can i require service_id through Euerka?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-718314185
> welcome to submit PR to support `service_id` for `limit-conn` or `limit-req`.
>
> they were should be the same as `limit-count`.
How ca i require service_id through Euerka?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-714398511
> 1. you need to use a better title.
> 2. one issue for one thing: add `service_id` as key to plugin `limit-*`, do you mean this?
now i set key in the following way,but service_id is nil.Why is that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715153152
> 2\. now i set key in the following way,but service_id is nil.Why is that?
do you bind any service to route?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-717983234
welcome to submit PR to support `service_id` for `limit-conn` or `limit-req`.
they were should be the same as `limit-count`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715192130
> > 2. now i set key in the following way,but service_id is nil.Why is that?
>
> do you bind any service to route?
yes
![Uploading services.png…]()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715193328
> > 2. now i set key in the following way,but service_id is nil.Why is that?
>
> do you bind any service to route?
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-715152058
I think we can support `service_id` as key to plugin `limit-count` first.
so you can update the title of this issue.
after we resolve this issue, you can create more issues for other limit-* plugins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-944891446
This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*
Posted by GitBox <gi...@apache.org>.
LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-717252358
> please make a try with the master branch ^_^
i still use the master branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org