You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bb...@apache.org on 2019/03/27 12:52:35 UTC
[mesos] 01/03: Made hashmap::containsValue consistent with stout
naming convention.
This is an automated email from the ASF dual-hosted git repository.
bbannier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit bb937aa7e34d407585219711d897af9c76f9a05e
Author: Benjamin Bannier <be...@mesosphere.io>
AuthorDate: Wed Mar 27 09:39:57 2019 +0100
Made hashmap::containsValue consistent with stout naming convention.
In stout we use snake case, not camel case.
We will clean up users outside of stout in a follow-up patch.
Review: https://reviews.apache.org/r/70249/
---
3rdparty/stout/include/stout/hashmap.hpp | 2 +-
3rdparty/stout/tests/hashmap_tests.cpp | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/3rdparty/stout/include/stout/hashmap.hpp b/3rdparty/stout/include/stout/hashmap.hpp
index 61bf80e..4ca88bc 100644
--- a/3rdparty/stout/include/stout/hashmap.hpp
+++ b/3rdparty/stout/include/stout/hashmap.hpp
@@ -89,7 +89,7 @@ public:
}
// Checks whether there exists a bound value in this map.
- bool containsValue(const Value& v) const
+ bool contains_value(const Value& v) const
{
foreachvalue (const Value& value, *this) {
if (value == v) {
diff --git a/3rdparty/stout/tests/hashmap_tests.cpp b/3rdparty/stout/tests/hashmap_tests.cpp
index 38a33dc..b333c56 100644
--- a/3rdparty/stout/tests/hashmap_tests.cpp
+++ b/3rdparty/stout/tests/hashmap_tests.cpp
@@ -94,10 +94,10 @@ TEST(HashMapTest, Contains)
map["abc"] = 1;
ASSERT_TRUE(map.contains("abc"));
- ASSERT_TRUE(map.containsValue(1));
+ ASSERT_TRUE(map.contains_value(1));
ASSERT_FALSE(map.contains("def"));
- ASSERT_FALSE(map.containsValue(2));
+ ASSERT_FALSE(map.contains_value(2));
}