You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/30 04:52:41 UTC
[GitHub] [arrow] emkornfield commented on a change in pull request #8293: ARROW-10127: Update specification for Decimal to allow for 256-bits
emkornfield commented on a change in pull request #8293:
URL: https://github.com/apache/arrow/pull/8293#discussion_r497241799
##########
File path: docs/source/format/CDataInterface.rst
##########
@@ -132,21 +132,23 @@ strings:
| ``g`` | float64 | |
+-----------------+--------------------------+------------+
-+-----------------+---------------------------------------+------------+
-| Format string | Arrow data type | Notes |
-+=================+=======================================+============+
-| ``z`` | binary | |
-+-----------------+---------------------------------------+------------+
-| ``Z`` | large binary | |
-+-----------------+---------------------------------------+------------+
-| ``u`` | utf-8 string | |
-+-----------------+---------------------------------------+------------+
-| ``U`` | large utf-8 string | |
-+-----------------+---------------------------------------+------------+
-| ``d:19,10`` | decimal128 [precision 19, scale 10] | |
-+-----------------+---------------------------------------+------------+
-| ``w:42`` | fixed-width binary [42 bytes] | |
-+-----------------+---------------------------------------+------------+
++-----------------+---------------------------------------------------+------------+
+| Format string | Arrow data type | Notes |
++=================+===================================================+============+
+| ``z`` | binary | |
++-----------------+---------------------------------------------------+------------+
+| ``Z`` | large binary | |
++-----------------+---------------------------------------------------+------------+
+| ``u`` | utf-8 string | |
++-----------------+---------------------------------------------------+------------+
+| ``U`` | large utf-8 string | |
++-----------------+---------------------------------------------------+------------+
+| ``d:19,10`` | decimal128 [precision 19, scale 10] | |
++-----------------+---------------------------------------------------+------------+
+| ``d:19,10,NNN`` | decimal bitwdith = NNN [precision 19, scale 10] | |
Review comment:
fixed.
##########
File path: format/Schema.fbs
##########
@@ -183,10 +183,8 @@ table Decimal {
/// Number of digits after the decimal point "."
scale: int;
- /// Number of bits per value. The only accepted width right now is 128 but
Review comment:
done.
##########
File path: format/Schema.fbs
##########
@@ -183,10 +183,8 @@ table Decimal {
/// Number of digits after the decimal point "."
scale: int;
- /// Number of bits per value. The only accepted width right now is 128 but
- /// this field exists for forward compatibility so that other bit widths may
- /// be supported in future format versions. We use bitWidth for consistency
- /// with Int::bitWidth.
+ /// Number of bits per value. The only accepted widths at 128 and 256.
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org