You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Matt Ryan (JIRA)" <ji...@apache.org> on 2018/10/11 22:28:00 UTC

[jira] [Commented] (OAK-7718) [DataStore] Refactor cloud data stores for better code reuse

    [ https://issues.apache.org/jira/browse/OAK-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647114#comment-16647114 ] 

Matt Ryan commented on OAK-7718:
--------------------------------

Additional PRs created for review:
 * [https://github.com/mattvryan/jackrabbit-oak/pull/17]
 * [https://github.com/mattvryan/jackrabbit-oak/pull/18]
 * [https://github.com/mattvryan/jackrabbit-oak/pull/19]
 * [https://github.com/mattvryan/jackrabbit-oak/pull/20]
 * [https://github.com/mattvryan/jackrabbit-oak/pull/21]
 * [https://github.com/mattvryan/jackrabbit-oak/pull/22]

After each previous review is complete, changes can be rolled up into subsequent reviews (they build on each other).  Once it has all been reviewed I'll squash all the changes down to a single commit.

 

> [DataStore] Refactor cloud data stores for better code reuse
> ------------------------------------------------------------
>
>                 Key: OAK-7718
>                 URL: https://issues.apache.org/jira/browse/OAK-7718
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: blob-cloud, blob-cloud-azure
>            Reporter: Matt Ryan
>            Assignee: Matt Ryan
>            Priority: Major
>
> Refactor the cloud data stores so that we can reuse code between them.
> Currently {{oak-blob-cloud}} exists for {{S3DataStore}} and {{oak-blob-cloud-azure}} for {{AzureDataStore}}.  There's no common codebase between them, other than {{oak-blob-plugins}} which seems a bit too broad for sharing code between the cloud data stores.
> The proposal is to repurpose {{oak-blob-cloud}} into common code for all cloud data stores, create {{oak-blob-cloud-s3}} for {{S3DataStore}}, and then move what common code that can be shared between the two into the new {{oak-blob-cloud}} module.
> This also would allow us to share testing code, which could be important especially for creating a cloud storage mock that will enable CI testing on the cloud data stores.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)