You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by li-zhihui <gi...@git.apache.org> on 2014/07/23 04:56:06 UTC

[GitHub] spark pull request: [SPARK-2635] Fix race condition at SchedulerBa...

Github user li-zhihui commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1525#discussion_r15269102
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ---
    @@ -47,19 +47,19 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, actorSystem: A
     {
       // Use an atomic variable to track total number of cores in the cluster for simplicity and speed
       var totalCoreCount = new AtomicInteger(0)
    -  var totalExpectedExecutors = new AtomicInteger(0)
    +  var totalExecutors = new AtomicInteger(0)
    +  var totalExpectedResources = new AtomicInteger(0)
       val conf = scheduler.sc.conf
       private val timeout = AkkaUtils.askTimeout(conf)
       private val akkaFrameSize = AkkaUtils.maxFrameSizeBytes(conf)
    -  // Submit tasks only after (registered executors / total expected executors) 
    +  // Submit tasks only after (registered resources / total expected resources) 
       // is equal to at least this value, that is double between 0 and 1.
    -  var minRegisteredRatio = conf.getDouble("spark.scheduler.minRegisteredExecutorsRatio", 0)
    +  var minRegisteredRatio = conf.getDouble("spark.scheduler.minRegisteredResourcesRatio", 0)
       if (minRegisteredRatio > 1) minRegisteredRatio = 1
    -  // Whatever minRegisteredExecutorsRatio is arrived, submit tasks after the time(milliseconds).
    +  // Whatever minRegisteredRatio is arrived, submit tasks after the time(milliseconds).
    --- End diff --
    
    good, thanks @markhamstra 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---