You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/03/26 17:32:05 UTC
[jira] [Created] (NET-391) CommandSupport listener should be
invoked before throwing an Exception if the reply is not valid
CommandSupport listener should be invoked before throwing an Exception if the reply is not valid
------------------------------------------------------------------------------------------------
Key: NET-391
URL: https://issues.apache.org/jira/browse/NET-391
Project: Commons Net
Issue Type: Bug
Affects Versions: 2.2
Reporter: Sebb
Assignee: Sebb
Priority: Minor
The __getReply() methods check for a valid reply, and throw an exception if the reply is unexpected.
However at present this is generally done before the CommandSupport listener has been informed, which means that the listener won't see the reply that caused the problem.
The methods should be changed to report the response before validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-391) CommandSupport listener should be
invoked before throwing an Exception if the reply is not valid
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated NET-391:
---------------------
Description:
The __getReply() methods check for a valid reply, and throw an exception if the reply is unexpected.
This is done before the CommandSupport listener is called, because the listener needs to be passed the reply code.
This means that the listener does not see invalid replies.
It might be useful to pass the reply to the listener even if the validation fails.
was:
The __getReply() methods check for a valid reply, and throw an exception if the reply is unexpected.
However at present this is generally done before the CommandSupport listener has been informed, which means that the listener won't see the reply that caused the problem.
The methods should be changed to report the response before validation.
Issue Type: Improvement (was: Bug)
> CommandSupport listener should be invoked before throwing an Exception if the reply is not valid
> ------------------------------------------------------------------------------------------------
>
> Key: NET-391
> URL: https://issues.apache.org/jira/browse/NET-391
> Project: Commons Net
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Sebb
> Assignee: Sebb
> Priority: Minor
>
> The __getReply() methods check for a valid reply, and throw an exception if the reply is unexpected.
> This is done before the CommandSupport listener is called, because the listener needs to be passed the reply code.
> This means that the listener does not see invalid replies.
> It might be useful to pass the reply to the listener even if the validation fails.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NET-391) CommandSupport listener should be
invoked before throwing an Exception if the reply is not valid
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-391.
----------------------
Resolution: Won't Fix
Assignee: (was: Sebb)
All the validation exceptions that can be thrown now include the line that caused the error, so this is not really needed.
> CommandSupport listener should be invoked before throwing an Exception if the reply is not valid
> ------------------------------------------------------------------------------------------------
>
> Key: NET-391
> URL: https://issues.apache.org/jira/browse/NET-391
> Project: Commons Net
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Sebb
> Priority: Minor
>
> The __getReply() methods check for a valid reply, and throw an exception if the reply is unexpected.
> This is done before the CommandSupport listener is called, because the listener needs to be passed the reply code.
> This means that the listener does not see invalid replies.
> It might be useful to pass the reply to the listener even if the validation fails.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira