You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/09/11 16:28:33 UTC

[GitHub] storm issue #2316: STORM-2734: Fix checkstyle crash when running release:pre...

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2316
  
    @revans2 It's not the goal itself, it's because the apache-release profile is activated https://svn.apache.org/viewvc/maven/pom/tags/apache-10/pom.xml?view=markup#l298. 
    
    In the 10 version of the Apache parent the apache-release profile adds a run of maven-source-plugin:jar, which forks the build and runs some phases (e.g. validate) even if they've already run. This causes checkstyle to run twice on all modules, which is usually not a problem. In storm-sql-core it happens to run both before and after some code generation, which breaks the build because Checkstyle crashes when checking the generated code.
    
    The 18 parent version switches to the jar-no-fork goal, which doesn't run checkstyle multiple times.
    
    Thanks for reviewing btw.


---