You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "erenavsarogullari (via GitHub)" <gi...@apache.org> on 2024/03/12 03:49:44 UTC
[PR] Port `ArrayRepeat` to `function-arrays` subcrate [arrow-datafusion]
erenavsarogullari opened a new pull request, #9568:
URL: https://github.com/apache/arrow-datafusion/pull/9568
## Which issue does this PR close?
Closes #9565.
## What changes are included in this PR?
This PR aims to do following changes in terms of Epic https://github.com/apache/arrow-datafusion/issues/9285:
1- `ArrayRepeat` is ported to `function-arrays` subcrate,
2- Minor cleanup by removing redundant package definitions.
## Are these changes tested?
Yes, all `array.slt` based `array_repeat` tests are passed.
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port `ArrayRepeat` to `functions-array` subcrate [arrow-datafusion]
Posted by "erenavsarogullari (via GitHub)" <gi...@apache.org>.
erenavsarogullari commented on PR #9568:
URL: https://github.com/apache/arrow-datafusion/pull/9568#issuecomment-1993652809
@jayzhan211 Thanks for triggering the build and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port `ArrayRepeat` to `functions-array` subcrate [arrow-datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #9568:
URL: https://github.com/apache/arrow-datafusion/pull/9568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port `ArrayRepeat` to `functions-array` subcrate [arrow-datafusion]
Posted by "erenavsarogullari (via GitHub)" <gi...@apache.org>.
erenavsarogullari commented on PR #9568:
URL: https://github.com/apache/arrow-datafusion/pull/9568#issuecomment-1993122884
Thanks @jayzhan211 and @comphead for the review. Merge conflict have just been addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port `ArrayRepeat` to `functions-array` subcrate [arrow-datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #9568:
URL: https://github.com/apache/arrow-datafusion/pull/9568#issuecomment-1993595270
> `cargo test (win64)` build stage is failed due to:
>
> ```
> error: could not remove 'setup' file: 'C:\Users\runneradmin\.cargo\bin/rustup-init.exe': Access is denied. (os error 5)
> ```
>
> Is it possible to re-trigger the build?
I had re-run it once, but the same error is occured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port `ArrayRepeat` to `functions-array` subcrate [arrow-datafusion]
Posted by "erenavsarogullari (via GitHub)" <gi...@apache.org>.
erenavsarogullari commented on PR #9568:
URL: https://github.com/apache/arrow-datafusion/pull/9568#issuecomment-1993461108
`cargo test (win64)` build stage is failed due to:
```
error: could not remove 'setup' file: 'C:\Users\runneradmin\.cargo\bin/rustup-init.exe': Access is denied. (os error 5)
```
Is it possible to re-trigger the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org