You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/20 02:54:13 UTC

[GitHub] [kafka] ableegoldman opened a new pull request #10735: KAFKA-12779: KIP-740, Clean up public API in TaskId and fix TaskMetadata#taskId()

ableegoldman opened a new pull request #10735:
URL: https://github.com/apache/kafka/pull/10735


   As described in [KIP-740](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=181306557), we clean up the public TaskId class and introduce new APIs to return it from TaskMetadata
   
   The KIP is currently under voting so this PR can't be merged yet, but it is ready to be reviewed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman merged pull request #10735: KAFKA-12779: KIP-740, Clean up public API in TaskId and fix TaskMetadata#taskId()

Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10735:
URL: https://github.com/apache/kafka/pull/10735


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #10735: KAFKA-12779: KIP-740, Clean up public API in TaskId and fix TaskMetadata#taskId()

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10735:
URL: https://github.com/apache/kafka/pull/10735#issuecomment-845505488


   Just some unrelated failures in `MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete()`, merging to trunk


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #10735: KAFKA-12779: KIP-740, Clean up public API in TaskId and fix TaskMetadata#taskId()

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10735:
URL: https://github.com/apache/kafka/pull/10735#issuecomment-844672950


   @cadonna @guozhangwang @vvcephei This PR is now ready to review -- I know the KIP is not yet accepted but you can still give this a pass to see what the proposal looks like, and start the review so I can get this merged soon after the KIP is voted on


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org