[jira] [Comment Edited] (OAK-552) AssertionError in MicroKernel.commit()

["Mete Atamel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551056#comment-13551056 ] 

Mete Atamel edited comment on OAK-552 at 1/11/13 11:40 AM:
-----------------------------------------------------------

Are sure sure the commit results in IllegalArgumentException? I get the following instead:

org.apache.jackrabbit.mk.api.MicroKernelException: org.apache.jackrabbit.mk.store.NotFoundException: /a/
	at org.apache.jackrabbit.mk.core.MicroKernelImpl.commit(MicroKernelImpl.java:506)
	at org.apache.jackrabbit.mk.test.MicroKernelIT.illegalTrailingSlash(MicroKernelIT.java:68)
...
Caused by: org.apache.jackrabbit.mk.store.NotFoundException: /a/
	at org.apache.jackrabbit.mk.model.StagedNodeTree.remove(StagedNodeTree.java:148)
	at org.apache.jackrabbit.mk.model.CommitBuilder$RemoveNode.apply(CommitBuilder.java:293)
	at org.apache.jackrabbit.mk.model.CommitBuilder.removeNode(CommitBuilder.java:67)
	at org.apache.jackrabbit.mk.core.MicroKernelImpl.commit(MicroKernelImpl.java:432)
	... 34 more


                
      was (Author: meteatamel):
    Are sure sure the commit results in IllegalArgumentException? I get the following instead:

org.apache.jackrabbit.mk.api.MicroKernelException: org.apache.jackrabbit.mk.store.NotFoundException: /a/
	at org.apache.jackrabbit.mk.core.MicroKernelImpl.commit(MicroKernelImpl.java:506)
	at org.apache.jackrabbit.mk.test.MicroKernelIT.illegalTrailingSlash(MicroKernelIT.java:68)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:24)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
Caused by: org.apache.jackrabbit.mk.store.NotFoundException: /a/
	at org.apache.jackrabbit.mk.model.StagedNodeTree.remove(StagedNodeTree.java:148)
	at org.apache.jackrabbit.mk.model.CommitBuilder$RemoveNode.apply(CommitBuilder.java:293)
	at org.apache.jackrabbit.mk.model.CommitBuilder.removeNode(CommitBuilder.java:67)
	at org.apache.jackrabbit.mk.core.MicroKernelImpl.commit(MicroKernelImpl.java:432)
	... 34 more


                  
> AssertionError in MicroKernel.commit()
> --------------------------------------
>
>                 Key: OAK-552
>                 URL: https://issues.apache.org/jira/browse/OAK-552
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: mk
>            Reporter: Michael Dürig
>
> {code}
> mk.commit("", "-\"/x/\"", null, null);
> {code}
> results in 
> {code}
> java.lang.AssertionError
> 	at org.apache.jackrabbit.oak.commons.PathUtils.concat(PathUtils.java:277)
> 	at org.apache.jackrabbit.mk.core.MicroKernelImpl.commit(MicroKernelImpl.java:437)
> 	at org.apache.jackrabbit.mk.MicroKernelImplTest.foo(MicroKernelImplTest.java:424)
> {code}
> since according to {{PathUtils}} {{/x/}} is not a valid path. 
> The commit method should throw an {{IllegalArgumentException}} instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira