You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by arunmahadevan <gi...@git.apache.org> on 2018/08/01 21:46:18 UTC

[GitHub] spark issue #21721: [SPARK-24748][SS] Support for reporting custom metrics v...

Github user arunmahadevan commented on the issue:

    https://github.com/apache/spark/pull/21721
  
    @HyukjinKwon , have addressed the comments and modified SourceProgress and SinkProgress to take String instead of JValue so that this can be easily used from Java. Regarding the default value in the ctor, I am not sure if its an issue because the object is mostly read only and would be an issue only if the user tries to construct it from Java. I have added overloaded ctors anyways. Please take a look.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org