You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/03 16:30:29 UTC

[GitHub] [spark] fqaiser94 commented on a change in pull request #29338: [SPARK-32521][SQL] Bug-fix: WithFields Expression should not be foldable

fqaiser94 commented on a change in pull request #29338:
URL: https://github.com/apache/spark/pull/29338#discussion_r464524653



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala
##########
@@ -1420,4 +1420,16 @@ class ColumnExpressionSuite extends QueryTest with SharedSparkSession {
       }.getMessage should include("No such struct field b in a, B")
     }
   }
+
+  test("SPARK-32521: withField with statically evaluable arguments should succeed") {

Review comment:
       Done. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org